From owner-freebsd-standards Tue Sep 24 4:10: 8 2002 Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A7D7A37B401 for ; Tue, 24 Sep 2002 04:10:06 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0370E43E77 for ; Tue, 24 Sep 2002 04:10:05 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g8OBA5Co021374 for ; Tue, 24 Sep 2002 04:10:05 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g8OBA5cD021373; Tue, 24 Sep 2002 04:10:05 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 947C737B40A; Tue, 24 Sep 2002 04:01:55 -0700 (PDT) Received: from fafoe.dyndns.org (chello212186121237.14.vie.surfer.at [212.186.121.237]) by mx1.FreeBSD.org (Postfix) with ESMTP id D226843E91; Tue, 24 Sep 2002 04:01:54 -0700 (PDT) (envelope-from stefan@fafoe.dyndns.org) Received: by frog.fafoe (Postfix, from userid 1001) id 264562C; Tue, 24 Sep 2002 13:01:54 +0200 (CEST) Message-Id: <20020924110154.264562C@frog.fafoe> Date: Tue, 24 Sep 2002 13:01:54 +0200 (CEST) From: Stefan Farfeleder Reply-To: Stefan Farfeleder To: FreeBSD-gnats-submit@FreeBSD.org Cc: mike@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: standards/43326: [PATCH?] needs previous inclusion of Sender: owner-freebsd-standards@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >Number: 43326 >Category: standards >Synopsis: [PATCH?] needs previous inclusion of >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-standards >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 24 04:10:05 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Stefan Farfeleder >Release: FreeBSD 5.0-CURRENT i386 >Organization: >Environment: System: FreeBSD frog.fafoe 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Mon Sep 23 18:09:18 CEST 2002 freebsd@frog.fafoe:/freebsd/current/obj/freebsd/current/src/sys/FROG i386 >Description: This commit: mike 2002/09/17 22:51:23 PDT Modified files: include nl_types.h sys/sys _types.h Log: Move definition of nl_item type to , so that it can be shared. Revision Changes Path 1.9 +5 -1 src/include/nl_types.h 1.8 +1 -0 src/sys/sys/_types.h made it necessary to include sys/_types.h before including nl_types.h since the new typedef of __nl_item was put into the former header. >How-To-Repeat: ports/x11-wm/blackbox doens't build anymore on -current because of this. According to catopen(3), the following test program should compile: #include int main(void) { catopen("", 0); return 0; } >Fix: If nl_types.h would include sys/_types.h itself instead of sys/cdefs.h, the old behaviour would be restored. I don't know whether this would introduce any namespace pollution. --- nl_types.h.orig Mon Sep 23 19:35:23 2002 +++ nl_types.h Tue Sep 24 12:03:27 2002 @@ -34,7 +34,7 @@ #ifndef _NL_TYPES_H_ #define _NL_TYPES_H_ -#include +#include #define NL_SETD 0 #define NL_CAT_LOCALE 1 >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-standards" in the body of the message