From owner-svn-src-all@freebsd.org Sun Jul 19 17:25:44 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A54669A611B; Sun, 19 Jul 2015 17:25:44 +0000 (UTC) (envelope-from markm@FreeBSD.org) Received: from gromit.grondar.org (grandfather.grondar.org [IPv6:2a01:348:0:15:5d59:5c20:0:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6DB6612C2; Sun, 19 Jul 2015 17:25:44 +0000 (UTC) (envelope-from markm@FreeBSD.org) Received: from graveyard.grondar.org ([88.96.155.33] helo=gronkulator.grondar.org) by gromit.grondar.org with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1ZGsLN-0003Rx-1t; Sun, 19 Jul 2015 18:25:41 +0100 Subject: Re: svn commit: r285692 - head/sys/dev/random Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: text/plain; charset=utf-8 From: Mark R V Murray In-Reply-To: <20150719170253.GO2404@kib.kiev.ua> Date: Sun, 19 Jul 2015 18:25:34 +0100 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201507191605.t6JG5V3o038572@repo.freebsd.org> <20150719170253.GO2404@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.2102) X-SA-Score: -1.0 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jul 2015 17:25:44 -0000 > On 19 Jul 2015, at 18:02, Konstantin Belousov = wrote: >=20 >> - printf("random: %s unblock wait\n", __func__); >> + /* Only bother the console every 10 seconds or so */ >> + if (spamcount =3D=3D 0) >> + printf("random: %s unblock wait\n", __func__); >> + spamcount =3D (spamcount + 1)%100; > Is ppsratecheck() not suitable for this due to use of > 1 sec period ? Oooh! Very probably, thank you. >> + error =3D tsleep(&random_alg_context, PCATCH, = "randseed", hz/10); >> + if ((error =3D=3D ERESTART | error =3D=3D EINTR)) > This is probably still valid, but I wonder if you mean || there. > Then you could also remove extra (). Oh, nuts. Got the wrong patch. Thank you. > All your commits are breaking all style(9) rules. It would be nice to = keep > the style at least for the files where you added random harvesting and = which > are already mostly style compliant. E.g., what about wrapping lines = at > position somewhere between 72 and 80 ? I=E2=80=99ll look, thanks! M --=20 Mark R V Murray