From owner-svn-src-head@freebsd.org Thu Dec 7 01:32:36 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAB66E94F80; Thu, 7 Dec 2017 01:32:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A64806DBF0; Thu, 7 Dec 2017 01:32:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id CC5D317A17; Thu, 7 Dec 2017 01:32:35 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id C041C2D3C; Thu, 7 Dec 2017 01:32:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id w-66iXFknJMD; Thu, 7 Dec 2017 01:32:32 +0000 (UTC) Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 92ACE2D37 To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> <19abac3b-8407-abd8-4fe9-c23d6bd7121f@selasky.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <5ad2e6ba-7209-0e20-bd69-f83ad3410b3a@FreeBSD.org> Date: Wed, 6 Dec 2017 17:32:35 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <19abac3b-8407-abd8-4fe9-c23d6bd7121f@selasky.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Pt86p2xO0PdBqJaipKAdPll2364Pq05dA" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 01:32:37 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Pt86p2xO0PdBqJaipKAdPll2364Pq05dA Content-Type: multipart/mixed; boundary="LNJf8ON5Umkt2hKaTkjD6uffkLlipksKH"; protected-headers="v1" From: Bryan Drewery To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <5ad2e6ba-7209-0e20-bd69-f83ad3410b3a@FreeBSD.org> Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> <19abac3b-8407-abd8-4fe9-c23d6bd7121f@selasky.org> In-Reply-To: <19abac3b-8407-abd8-4fe9-c23d6bd7121f@selasky.org> --LNJf8ON5Umkt2hKaTkjD6uffkLlipksKH Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/6/2017 4:53 PM, Hans Petter Selasky wrote: > It would be nice if these utilities can be built standalone, outside th= e > buildworld target aswell. I've suggested adding an "all-install" varian= t > to make. Having to kick a buildworld to test-build contrib/ofed is quit= e > overkill, and that is some of reasoning behind the current Makefile lay= out. This is what buildworld+SUBDIR_OVERRIDE is for. The following patch also mitigates the need to install libraries for build testing which I'll commit tomorrow: > commit 7cce144e821cbf2f4e70711928a8945137700b35 (HEAD -> master) > Author: Bryan Drewery > Date: Wed Dec 6 17:29:57 2017 -0800 >=20 > Look for libraries in OBJDIR when building outside of buildworld. >=20 > This allows build testing more easily without establishing a sysroo= t > or installing the files. >=20 > Sponsored by: Dell EMC >=20 > diff --git share/mk/src.libnames.mk share/mk/src.libnames.mk > index 2d172197ac53..fdd1a4866620 100644 > --- share/mk/src.libnames.mk > +++ share/mk/src.libnames.mk > @@ -359,7 +359,7 @@ LIB${_l:tu}?=3D ${LIBDESTDIR}${LIBDIR_BASE}/l= ibprivate${_l}.a > .endfor >=20 > .for _l in ${_LIBRARIES} > -.if ${_INTERNALLIBS:M${_l}} > +.if ${_INTERNALLIBS:M${_l}} || !defined(SYSROOT) > LDADD_${_l}_L+=3D -L${LIB${_l:tu}DIR} > .endif > DPADD_${_l}?=3D ${LIB${_l:tu}} --=20 Regards, Bryan Drewery --LNJf8ON5Umkt2hKaTkjD6uffkLlipksKH-- --Pt86p2xO0PdBqJaipKAdPll2364Pq05dA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaKJozAAoJEDXXcbtuRpfPHKwH/2qhORRAkFUbrzKO5BrnkHVP 7nA/N1QCKUyrFBD6zaAGSM12nkEHk642qFfoyK2ddFNZc9HgUt/7CzYNMuqbv3HI E+Fg+hyOC6DbE+tSIy2a1Wq9AopBMJoi73TbMwbgrLt9VnPIiiDH/4Q1yFhuMHzl Un4hp4LyyeGVN2sle2I9jHfHYt0+3G1HGZ0KyOVCcOcwOg8fksNspUiML72ItrEt Gqq3nxJ/1dzjWN7GW2vBDqWBHn1WIklMXRedWuYd4QA67Br+ELItcAWVg3c3zsba T9+gF9UuRZj/6CfZfpbQHaAw9xCjBf3DnNCl9dyuGWzxvnBGOzuSCXAacY2SFS4= =fu/l -----END PGP SIGNATURE----- --Pt86p2xO0PdBqJaipKAdPll2364Pq05dA--