From owner-freebsd-testing@freebsd.org Mon Jun 29 16:35:52 2015 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2477098FF7E; Mon, 29 Jun 2015 16:35:52 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from mx2.freebsd.org (mx2.freebsd.org [8.8.178.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx2.freebsd.org", Issuer "Gandi Standard SSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1128225B7; Mon, 29 Jun 2015 16:35:52 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from hammer.pct.niksun.com (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx2.freebsd.org (Postfix) with ESMTP id 87EAB1659; Mon, 29 Jun 2015 16:35:51 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Message-ID: <559173E7.30603@FreeBSD.org> Date: Mon, 29 Jun 2015 12:35:51 -0400 From: Jung-uk Kim User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Craig Rodrigues CC: George Neville-Neil , "freebsd-testing@freebsd.org" , "freebsd-java@freebsd.org" Subject: Re: Requests for Help: add FreeBSD procstat support to akuma library for Jenkins References: <8CA148D7-81AF-41F8-AA41-9D7700B27242@neville-neil.com> <558C62B6.6030004@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 16:35:52 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/28/2015 17:15, Craig Rodrigues wrote: > On Thu, Jun 25, 2015 at 4:21 PM, Jung-uk Kim > wrote: > > You can try the attached trivial patch. Note it requires > procfs(5). > > > Thanks for submitting that patch. I thought about something like > that before. > > I am hesitant about pushing this patch upstream, because it would > make akuma + Jenkins dependent on procfs. This dependency would be > new, since FreeBSD procfs is not mandatory and only available as > an option. > > Since procstat has been available in the base system since FreeBSD > 7.1, I recommended using that in the akuma library, even though it > is a little bit more work to implement. Although I agree that using procfs is not ideal, we already use procfs for Java implementations. https://svnweb.freebsd.org/ports/head/java/openjdk6/pkg-message?revision=340719&view=co https://svnweb.freebsd.org/ports/head/java/openjdk7/pkg-message?revision=357236&view=co https://svnweb.freebsd.org/ports/head/java/openjdk8/pkg-message?revision=349468&view=co I don't see any reason to prefer procstat. Jung-uk Kim -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVkXPnAAoJEHyflib82/FG/7YH/jkfoWyOQ3e/8kGcP0GhUK3q EBBHzvvgOy/KiCnVsRdDNsTKo6RoI2jh9z+zPsf/AoPCi9mFalLWhQM5TSIVzBbM 8nmOKtIj58fCkquBVRsWC2cDDlCB+A04O0/rukLYDDxLIL5dDxTdD0ZgWJ5/JsT7 zZQ6qoLtGwF7FvmHQ8u8LQ70HZHjBbZ9I7QgmbwqtkSF1pXBf/mKyucKBoKmxPlc /V2IdNKbpxGVclFwfg2SYR73Cbo6au7GEIKDJ4ud0lpo7hmQlefA87qg3P+n8/yI ZUUGSoNzNrB4rxdjT8DY9fSEqYu+JYdt67dsbZd5laKQn9ZiKpd/L/uZvrJCxXo= =RMCF -----END PGP SIGNATURE-----