From owner-cvs-src@FreeBSD.ORG Sun Aug 24 11:36:49 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D099716A4BF; Sun, 24 Aug 2003 11:36:49 -0700 (PDT) Received: from puma.icir.org (puma.icir.org [192.150.187.73]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1F4BE43F85; Sun, 24 Aug 2003 11:36:49 -0700 (PDT) (envelope-from hodson@puma.icir.org) Received: from puma.icir.org (localhost [127.0.0.1]) by puma.icir.org (8.12.8p1/8.12.3) with ESMTP id h7OIan91084617; Sun, 24 Aug 2003 11:36:49 -0700 (PDT) (envelope-from hodson@puma.icir.org) Message-Id: <200308241836.h7OIan91084617@puma.icir.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.3 To: obrien@FreeBSD.org From: Orion Hodson In-Reply-To: Your message of "Sun, 24 Aug 2003 10:28:55 PDT." <20030824172855.GA98809@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 24 Aug 2003 11:36:49 -0700 Sender: hodson@icir.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sound/pcm ac97.c ac97.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2003 18:36:50 -0000 /-- "David O'Brien" wrote: | On Thu, Aug 21, 2003 at 08:50:33AM -0700, Orion Hodson wrote: | > orion 2003/08/21 08:50:33 PDT | > Modified files: | > sys/dev/sound/pcm ac97.c ac97.h | > Log: | > Apply Rudolf Cejka's patch for: | > o AD1980 hook. | > o ac97_fix_auxout. | > and: | > o Associate AC97_MIX_AUXOUT with SOUND_MIXER_OGAIN rather than | > SOUND_MIXER_MONITOR. | > o Add ac97_fix_tone to remove tone controls from mixer if invalid. | > | > Revision Changes Path | > 1.43 +42 -47 src/sys/dev/sound/pcm/ac97.c | > http://cvsweb.freebsd.org/src/sys/dev/sound/pcm/ac97.c.diff?r1=1.42&r2=1.43 | > 1.14 +1 -1 src/sys/dev/sound/pcm/ac97.h | > http://cvsweb.freebsd.org/src/sys/dev/sound/pcm/ac97.h.diff?r1=1.13&r2=1.14 | | -#define AC97_MUTE 0x8000 | +#define AC97_MUTE 0x8080 | | this now conficts with gnu/dev/sound/pci/emu10k1-ac97.h which is needed | for Audigy2 support. Why the change? Because this is the appropriate value for the center/LFE and surround volume controls (ac97 registers 0x36 and 0x38). The latter is used in Rudolf's patch. For the registers where 0x8000 corresponds to the mute bit, it's not-critical whether the additional bit is set or not: the bit is marked as reserved in the spec and by the specs words may be written, but must return 0 upon read back. What is the status of the Audigy2 support? - Orion