From owner-freebsd-net@FreeBSD.ORG  Wed Sep  5 06:05:51 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6A4C4106564A;
	Wed,  5 Sep 2012 06:05:51 +0000 (UTC)
	(envelope-from pyunyh@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 2C8308FC18;
	Wed,  5 Sep 2012 06:05:51 +0000 (UTC)
Received: by pbbrp2 with SMTP id rp2so384252pbb.13
	for <multiple recipients>; Tue, 04 Sep 2012 23:05:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=from:date:to:cc:subject:message-id:reply-to:references:mime-version
	:content-type:content-disposition:in-reply-to:user-agent;
	bh=SIf/CB0xYf4ITgftxI5PCAwEr6+dPTY+CAVsIMIkm5U=;
	b=yMdwX1O3xlcPM8oNu9nIBCcR2j885hml7eWHKq6+2AdEJTtDiXwhkHc4OjCqdV6bIm
	C8aaMX1GT7/gZ30F36ePN4u+NaxrqDRoz9zUbNUiu8C53JFzvl8fOZQqiyU63omdZF8o
	TXXawFJSAifvdst752/sqir2vsBMPgGrHl/93w1RL1fcpEZRko5br7CaAWJ7tLP5h4bH
	JW+Q6Od+C1mZASgzD3ReQPwa9VCNx2V1KHvpwiFvXLdeSLpp0MzTN3oAcmb6EjySTDAo
	i0OYABQ44hgUADg7xF0H1TQPzKcZj0NpskqbxTNyF05m4et+DBFs0yqgE85JfaMcYbjG
	SO0Q==
Received: by 10.68.220.201 with SMTP id py9mr51252049pbc.137.1346825150837;
	Tue, 04 Sep 2012 23:05:50 -0700 (PDT)
Received: from pyunyh@gmail.com (lpe4.p59-icn.cdngp.net. [114.111.62.249])
	by mx.google.com with ESMTPS id pj8sm691377pbb.60.2012.09.04.23.05.47
	(version=TLSv1/SSLv3 cipher=OTHER);
	Tue, 04 Sep 2012 23:05:50 -0700 (PDT)
Received: by pyunyh@gmail.com (sSMTP sendmail emulation);
	Wed, 05 Sep 2012 15:05:41 -0700
From: YongHyeon PYUN <pyunyh@gmail.com>
Date: Wed, 5 Sep 2012 15:05:41 -0700
To: Mike Silbersack <silby@silby.com>
Message-ID: <20120905220541.GB1449@michelle.cdnetworks.com>
References: <5046D681.2040806@silby.com>
	<20120905205654.GA1449@michelle.cdnetworks.com>
	<5046DEF2.9040901@silby.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5046DEF2.9040901@silby.com>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-net@freebsd.org, davidch@freebsd.org, yongari@freebsd.org
Subject: Re: [patch] if_bxe shutdown fix
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: pyunyh@gmail.com
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Sep 2012 06:05:51 -0000

On Wed, Sep 05, 2012 at 12:11:14AM -0500, Mike Silbersack wrote:
> On 9/5/12 3:56 PM, YongHyeon PYUN wrote:
> >On Tue, Sep 04, 2012 at 11:35:13PM -0500, Mike Silbersack wrote:
> >>Does anyone want to review this patch before I check it in?  The change
> >>has been reviewed and tested by coworkers, but not yet reviewed by any
> >>other FreeBSD committers.
> >>
> >>http://www.silby.com/patches/if_bxe.c-safestop.patch
> >>
> >>This resolves an issue we saw at work where IPMI would report bus errors
> >>when you rebooted a system with bxe NICs if you had not UP'd all of the
> >>bxe NICs before the shutdown.
> >Yeah I also have a similar patch. But I checked sc->state after
> >getting a BXE_CORE_LOCK as the state is protected by the lock.
> >
> >>Thanks,
> >>
> >>Mike "Silby" Silbersack
> 
> Good catch.  How does this look?
> 
> http://www.silby.com/patches/if_bxe.c-safestop-2.patch
> 

Patch looks good to me.