Date: Wed, 20 Jun 2012 01:16:18 GMT From: "4721@hushmail.com" <4721@hushmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/169250: [patch] switch graphics/ImageMagick to build with clang Message-ID: <201206200116.q5K1GIWx082611@red.freebsd.org> Resent-Message-ID: <201206200120.q5K1K9HS044202@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169250
>Category: ports
>Synopsis: [patch] switch graphics/ImageMagick to build with clang
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 20 01:20:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: 4721@hushmail.com
>Release:
>Organization:
>Environment:
>Description:
switch ImageMagick to clang build solves two build/test problems.
test failures of 165535:
FAIL: tests/validate-formats-in-memory.sh
FAIL: tests/validate-formats-on-disk.sh
build failure of 169066:
CC coders/coders_hdr_la-hdr.lo
coders/hald.c: In function 'ReadHALDImage':
coders/hald.c:128: error: expected '#pragma omp' clause before 'dynamic_number_threads'
gmake[1]: *** [coders/coders_hald_la-hald.lo] Error 1
with clang:
PASS: tests/validate-formats-in-memory.sh
PASS: tests/validate-formats-on-disk.sh
CC coders/coders_hald_la-hald.lo
CC coders/coders_hdr_la-hdr.lo
CC coders/coders_histogram_la-histogram.lo
tested on 8.3-amd64. note that build/test failures also can be fixed by using
lang/gcc46.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- graphics/ImageMagick/Makefile
+++ graphics/ImageMagick/Makefile
@@ -35,6 +35,11 @@
CPPFLAGS+= -I${LOCALBASE}/include
LDFLAGS+= -L${LOCALBASE}/lib
+CC= clang
+CXX= clang++
+.if !exists(/usr/bin/clang)
+BUILD_DEPENDS+= ${LOCALBASE}/bin/clang:${PORTSDIR}/lang/clang
+.endif
PLIST_SUB= PORTVERSION=${PORTVERSION:R}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206200116.q5K1GIWx082611>