From owner-freebsd-current Wed Jan 27 22:20:15 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA20964 for freebsd-current-outgoing; Wed, 27 Jan 1999 22:20:15 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA20949 for ; Wed, 27 Jan 1999 22:20:11 -0800 (PST) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id XAA11103; Wed, 27 Jan 1999 23:20:07 -0700 (MST) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id XAA26671; Wed, 27 Jan 1999 23:20:06 -0700 Date: Wed, 27 Jan 1999 23:20:06 -0700 Message-Id: <199901280620.XAA26671@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: John Birrell Cc: nate@mt.sri.com (Nate Williams), archie@whistle.com, wollman@khavrinen.lcs.mit.edu, current@FreeBSD.ORG Subject: Re: btokup() macro in sys/malloc.h In-Reply-To: <199901280558.QAA07918@cimlogic.com.au> References: <199901280540.WAA26288@mt.sri.com> <199901280558.QAA07918@cimlogic.com.au> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > 'warnings' fixes will be wrong and hide bogus code), making -Wall a goal > > causes people to cover up bad code with bad casts and such. > > > > '-Wall' is *NOT* a good design goal. > > Fixing warnings with bad casts is a problem, sure, but asking people > to write code without casts (if possible) that will compile cleanly with > -Wall is a reasonable thing to ask IMO. Agreed. But most of the new code written does indeed compile with -Wall. It's the code we've 'inherited' that doesn't. > In my experience, the resulting > code tends to be more portable across architectures with different > pointer/long sizes and endian-ness. This is where I disagree. Too often people cast away the bugs and end up with overflow and sign problems. Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message