From owner-freebsd-fs@FreeBSD.ORG  Thu Sep 19 00:24:34 2013
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 41423D1C;
 Thu, 19 Sep 2013 00:24:34 +0000 (UTC)
 (envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (chez.mckusick.com
 [IPv6:2001:5a8:4:7e72:4a5b:39ff:fe12:452])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0B4CC2F1E;
 Thu, 19 Sep 2013 00:24:33 +0000 (UTC)
Received: from chez.mckusick.com (localhost [127.0.0.1])
 by chez.mckusick.com (8.14.3/8.14.3) with ESMTP id r8J0ORZD097969;
 Wed, 18 Sep 2013 17:24:28 -0700 (PDT)
 (envelope-from mckusick@chez.mckusick.com)
Message-Id: <201309190024.r8J0ORZD097969@chez.mckusick.com>
To: "Teske, Devin" <Devin.Teske@fisglobal.com>
Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?) 
In-reply-to: <13CA24D6AB415D428143D44749F57D720FBD7C18@LTCFISWMSGMB21.FNFIS.com>
Date: Wed, 18 Sep 2013 17:24:27 -0700
From: Kirk McKusick <mckusick@mckusick.com>
Cc: freebsd-fs <freebsd-fs@freebsd.org>, bug-followup@freebsd.org
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Sep 2013 00:24:34 -0000

> From: "Teske, Devin" <Devin.Teske@fisglobal.com>
> To: Rick Macklem <rmacklem@uoguelph.ca>
> Subject: Re: kern/182181: [ufs] Leakage of vnode references (race condition?)
> Date: Thu, 19 Sep 2013 00:11:03 +0000
> Cc: freebsd-fs <freebsd-fs@freebsd.org>,
>         "Teske, Devin" <Devin.Teske@fisglobal.com>
> 
> On Sep 18, 2013, at 5:05 PM, Rick Macklem wrote:
> 
>> Devin Teske wrote:
>>> 
>>> 
>>> Yes, my confusion was...
>>> 
>>> 1. The PR headers say 8.4-RELEASE-p3 is affected
>>> 
>>> 2. The PR's "How-To-Repeat" starts with "Install a releng/8.4 branch"
>>> 
>>> Yet...
>>> 
>>> releng/8.4 and even releng/8.3 both use VOP_UNLOCK instead of vput
>>> (read: are patched).
>>> 
>> Did you mean "not patched"? The patched version in head has vput()
>> and the unpatched versions have VOP_UNLOCK(), if I read the coed correctly.
>> 
> 
> Well, Kirk's fat-finger made me think that VOP_UNLOCK was the patched-
> state and vput was the unpatched state. (could also be that I'm fighting
> the flu currently).
> 
> So everything is copacetic now, except the one outstanding question...
> 
> Should we not MFC r253998 to stable/8?
> 
> I'm looking to pull this into our own stable/8 kernel, but would
> like to do it by way of svn merge from the stable/8 branch.
> -- 
> Devin

Per your request, I have MFC'ed the patch to 8-stable as revision 255681.

	Kirk McKusick