Date: Sun, 26 May 2013 11:28:44 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r319044 - head/graphics/togl Message-ID: <20130526112844.GA66781@FreeBSD.org> In-Reply-To: <201305251106.r4PB60W3082544@svn.freebsd.org> References: <201305251106.r4PB60W3082544@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 25, 2013 at 11:06:00AM +0000, Pietro Cerutti wrote: > New Revision: 319044 > URL: http://svnweb.freebsd.org/changeset/ports/319044 > > Log: > - Append to instead of overwrite CONFIGURE_ARGS > > @@ -23,7 +19,7 @@ USE_TK_BUILD= 84+ > USE_TK= 84+ > USE_GMAKE= yes > GNU_CONFIGURE= yes > -CONFIGURE_ARGS= --with-tk=${TK_LIBDIR} \ > +CONFIGURE_ARGS+=--with-tk=${TK_LIBDIR} \ > --with-tcl=${TCL_LIBDIR} \ > --with-tclinclude=${TCL_INCLUDEDIR} What was wrong with =, that is, overwriting an empty variable? Appending can be required for slave ports, for example, but to me it merely makes things more confusing here (unless I'm missing something -- but then again, commit log did not mention it). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130526112844.GA66781>