From owner-svn-src-all@FreeBSD.ORG  Tue Mar  2 20:29:48 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 700B71065670;
	Tue,  2 Mar 2010 20:29:48 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B6978FC0C;
	Tue,  2 Mar 2010 20:29:48 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o22KJ0JM068117;
	Tue, 2 Mar 2010 13:19:00 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 02 Mar 2010 13:19:12 -0700 (MST)
Message-Id: <20100302.131912.119882392285757630.imp@bsdimp.com>
To: kostikbel@gmail.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20100302192845.GD2489@deviant.kiev.zoral.com.ua>
References: <20100302185130.GC2489@deviant.kiev.zoral.com.ua>
	<20100302190344.GA5490@onelab2.iet.unipi.it>
	<20100302192845.GD2489@deviant.kiev.zoral.com.ua>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, rizzo@iet.unipi.it
Subject: Re: svn commit: r204591 - in head: sbin/ipfw sys/conf sys/net
 sys/netinet sys/netinet/ipfw sys/netinet/ipfw/test
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Mar 2010 20:29:48 -0000

In message: <20100302192845.GD2489@deviant.kiev.zoral.com.ua>
            Kostik Belousov <kostikbel@gmail.com> writes:
: On Tue, Mar 02, 2010 at 08:03:44PM +0100, Luigi Rizzo wrote:
: > On Tue, Mar 02, 2010 at 08:51:30PM +0200, Kostik Belousov wrote:
: > ...
: > > > --- head/sbin/ipfw/Makefile	Tue Mar  2 17:34:11 2010	(r204590)
: > > > +++ head/sbin/ipfw/Makefile	Tue Mar  2 17:40:48 2010	(r204591)
: > > > @@ -3,7 +3,6 @@
: > > >  PROG=	ipfw
: > > >  SRCS=	ipfw2.c dummynet.c ipv6.c main.c nat.c altq.c
: > > >  WARNS?=	2
: > > > -DPADD=	${LIBUTIL}
: > > >  LDADD=	-lutil
: > > >  MAN=	ipfw.8
: > > Removal of DPADD is most likely regression ?
: > 
: > possibly.
: > i couldn't figure out why it was there in the
: > first place, can you clarify what it was for ?
: To depend on the libutil, so that ipfw is reloaded when libutil.a is
: changed.
: 
: The question I do not know answer for, is why do we need LDADD.

DPADD is used to add the static file (/usr/lib/libutil.a).  LDADD is
used to add the library to the command line (-lutil).  IIRC, it isn't
always possible to map one to the other, but I've never explored why...

Warner