From owner-svn-src-stable-11@freebsd.org Thu Mar 29 01:53:53 2018 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEC17F637D4 for ; Thu, 29 Mar 2018 01:53:52 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x234.google.com (mail-yb0-x234.google.com [IPv6:2607:f8b0:4002:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D5FB70328 for ; Thu, 29 Mar 2018 01:53:52 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x234.google.com with SMTP id d7-v6so1257300ybn.9 for ; Wed, 28 Mar 2018 18:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=b6SJyyfjDrT6hVQ/L1rI9IYLFwd+/eyg1fstZ2h/kKc=; b=d1ltj6DzqHJjchMaKbSl2nVwChadwTKkvaWUtbvFWu+DwgA5dZSkKOIhP5yAQmaTcl 2mglTbntTkfJiZF6HNLO/k77yH7/hvD5F0aCSnWHgLdNXq1LPIhlWb3Wa6Qm6vMSRNXX JVnVixrQ0/SomRGOw11SZbFCr4Q4BYp16GZSQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=b6SJyyfjDrT6hVQ/L1rI9IYLFwd+/eyg1fstZ2h/kKc=; b=ohIZup2kYV0qVqETRI2h85wBeYfGtB2QNLG5p7cMNz7stp9S64UxymDTm1isdOYJkr 3huVnPa34ho8CEn+fTM7xW7eLZvXkZLcGju+APZShEXYHwcqqv6R04YxpDDJHFIAvQgg +KSy2ruvMwlzG/gdZRyYwyAbrg2vDxGdECRfz5t+6RsOACuCw/+vz7mSwcvBGaOCPCwL eiy/o6Fwx4tEWXUmJvprPChFThNPaqzLEkxVyidqRt+L4NCniDMeM4miqLLOuxv0zQRJ LfTsCvA3bXPFFpB++fmzpRnyBz5pKeruyWHFPn1jmFjnlOliegN/6I8Uo94mMTA8i9yY B2bA== X-Gm-Message-State: AElRT7Fo8G+EYmVSxPJxu3VIuUQuCHJ/co4CCSRNsD3SoaZ1KRawwisk CWjCjw3pOq99fmshiey5WABIrkcLooeJd/R4fa/Hsg== X-Google-Smtp-Source: AIpwx48wCDW3YMDfihpXMfKdmCL2ttuMfhHY0o4ndy15As6NFcoINAroqZJRwUOXNvEYQmvLz5GAlbWFnH6r6dBoEII= X-Received: by 2002:a25:d213:: with SMTP id j19-v6mr3760738ybg.338.1522288431635; Wed, 28 Mar 2018 18:53:51 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 2002:a5b:990:0:0:0:0:0 with HTTP; Wed, 28 Mar 2018 18:53:21 -0700 (PDT) In-Reply-To: <201803290135.w2T1Z7hU060080@pdx.rh.CN85.dnsmgr.net> References: <201803290135.w2T1Z7hU060080@pdx.rh.CN85.dnsmgr.net> From: Eitan Adler Date: Wed, 28 Mar 2018 18:53:21 -0700 X-Google-Sender-Auth: FNFLSY7U9_SkMjY_v9J4Jy7Qq6U Message-ID: Subject: Re: Mismerge at r330897 in stable/11, Audit report To: rgrimes@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org, FreeBSD Release Engineering Team Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 01:53:53 -0000 On 28 March 2018 at 18:35, Rodney W. Grimes wrote: >> >> Hi! >> >> >> >> This part of the MFC is wrong: >> >> >> >> https://svnweb.freebsd.org/base/stable/11/sys/sys/random.h?limit_changes=0&r1=330897&r2=330896&pathrev=330897 > > Can we try to identify exactly what rXXXXXX that is a merge of? > >> >> Could you please MFC back the other random related changes too? Some >> >> of them made by cem@. >> >> >> >> On 3/14/18, Eitan Adler wrote: >> >>> Author: eadler >> >>> Date: Wed Mar 14 03:19:51 2018 >> >>> New Revision: 330897 >> >>> URL: https://svnweb.freebsd.org/changeset/base/330897 >> >>> >> >>> Log: >> >>> Partial merge of the SPDX changes >> >>> >> >>> These changes are incomplete but are making it difficult >> >>> to determine what other changes can/should be merged. >> >>> >> >>> No objections from: pfg >> >>> >> > Am I missing something? If this MFC was supposed to be of the SPDX >> > license tagging, why does it have any functional changes? >> > >> > Especially changes to random(4)? >> >> This was my failure. I only spot checked & compile-checked the diff >> since I expected all changes to be comments/SPDX. >> >> However, I must have gotten carried away and included a few too many >> revisions. Unfortunately some people have already merged fixes to my >> failure and thus this can't be reverted as is without also reverting >> those fixes. >> >> That said, I should do that since this commit message is utterly wrong. > > We do not have to revert r330897, with what follows I think > we can easily find the revisions to revert from stable/11. > ... While we don't have to revert it I'd rather do so than have bogus history. >From a look it seems the following was also merged: r316370, r317095, r324394, and a few others. Is there a reason you don't want me to revert the changes? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams