Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Apr 2018 06:49:22 +0200
From:      Emmanuel Vadot <manu@bidouilliste.com>
To:        Marcin Wojtas <mw@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r333035 - head/sys/arm/conf
Message-ID:  <20180427064922.4a4a1746c799d4bd0b686556@bidouilliste.com>
In-Reply-To: <201804261923.w3QJNchI057529@repo.freebsd.org>
References:  <201804261923.w3QJNchI057529@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

 Hi Marcin,

On Thu, 26 Apr 2018 19:23:38 +0000 (UTC)
Marcin Wojtas <mw@FreeBSD.org> wrote:

> Author: mw
> Date: Thu Apr 26 19:23:37 2018
> New Revision: 333035
> URL: https://svnweb.freebsd.org/changeset/base/333035
> 
> Log:
>   Add Marvell ArmadaXP and Armada38X to GENERIC config
>   
>   Include source files and drivers for Marvell ArmadaXP and Armada38X
>   in GENERIC kernel config.
>   
>   Submitted by: Michal Mazur <mkm@semihalf.com>
>   	      Rafal Kozik <rk@semihalf.com>
>   Obtained from: Semihalf
>   Sponsored by: Stormshield
>   Differential Revision: https://reviews.freebsd.org/D14747
> 
> Modified:
>   head/sys/arm/conf/GENERIC

 This break GENERIC when running on !marvell.

 The code in sys/arm/mv/mv_common.c tries to read a register in a
memory region that doesn't exist in !marvell (in soc_id).

 Could you revert this commit please.

 Thanks,

-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180427064922.4a4a1746c799d4bd0b686556>