From owner-svn-src-head@FreeBSD.ORG Mon Oct 31 17:37:30 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EB8F1065677 for ; Mon, 31 Oct 2011 17:37:30 +0000 (UTC) (envelope-from pho@holm.cc) Received: from relay00.pair.com (relay00.pair.com [209.68.5.9]) by mx1.freebsd.org (Postfix) with SMTP id BC7A88FC0A for ; Mon, 31 Oct 2011 17:37:29 +0000 (UTC) Received: (qmail 488 invoked from network); 31 Oct 2011 17:10:45 -0000 Received: from 87.58.144.241 (HELO x2.osted.lan) (87.58.144.241) by relay00.pair.com with SMTP; 31 Oct 2011 17:10:45 -0000 X-pair-Authenticated: 87.58.144.241 Received: from x2.osted.lan (localhost [127.0.0.1]) by x2.osted.lan (8.14.4/8.14.4) with ESMTP id p9VHAhBJ029715; Mon, 31 Oct 2011 18:10:43 +0100 (CET) (envelope-from pho@x2.osted.lan) Received: (from pho@localhost) by x2.osted.lan (8.14.4/8.14.4/Submit) id p9VHAh2U029714; Mon, 31 Oct 2011 18:10:43 +0100 (CET) (envelope-from pho) Date: Mon, 31 Oct 2011 18:10:43 +0100 From: Peter Holm To: John Baldwin Message-ID: <20111031171043.GB29244@x2.osted.lan> References: <201110311501.p9VF1lrf020688@svn.freebsd.org> <201110311241.42067.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201110311241.42067.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226967 - head/sys/ufs/ufs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2011 17:37:30 -0000 On Mon, Oct 31, 2011 at 12:41:41PM -0400, John Baldwin wrote: > On Monday, October 31, 2011 11:01:47 am Peter Holm wrote: > > Author: pho > > Date: Mon Oct 31 15:01:47 2011 > > New Revision: 226967 > > URL: http://svn.freebsd.org/changeset/base/226967 > > > > Log: > > The kern_renameat() looks up the fvp using the DELETE flag, which causes > > the removal of the name cache entry for fvp. > > > > Reported by: Anton Yuzhaninov > > In collaboration with: kib > > MFC after: 1 week > > Hmm, the log message doesn't seem to quite match the change? Was it > truncated? > No, it was a misunderstanding on my part. The log message should have read: "Added missing cache purge of from argument." - Peter > > Modified: > > head/sys/ufs/ufs/ufs_vnops.c > > > > Modified: head/sys/ufs/ufs/ufs_vnops.c > > > ============================================================================== > > --- head/sys/ufs/ufs/ufs_vnops.c Mon Oct 31 10:53:27 2011 (r226966) > > +++ head/sys/ufs/ufs/ufs_vnops.c Mon Oct 31 15:01:47 2011 (r226967) > > @@ -1519,6 +1519,13 @@ relock: > > cache_purge(fdvp); > > } > > error = ufs_dirremove(fdvp, fip, fcnp->cn_flags, 0); > > + /* > > + * As the relookup of the fvp is done in two steps: > > + * ufs_lookup_ino() and then VFS_VGET(), another thread might do a > > + * normal lookup of the from name just before the VFS_VGET() call, > > + * causing the cache entry to be re-instantiated. > > + */ > > + cache_purge(fvp); > > > > unlockout: > > vput(fdvp); > > > > -- > John Baldwin