From owner-freebsd-toolchain@FreeBSD.ORG  Thu Apr 30 15:08:17 2015
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: freebsd-toolchain@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 26EC76CB
 for <freebsd-toolchain@freebsd.org>; Thu, 30 Apr 2015 15:08:17 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 059A715D4
 for <freebsd-toolchain@freebsd.org>; Thu, 30 Apr 2015 15:08:17 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t3UF8GTc051178
 for <freebsd-toolchain@freebsd.org>; Thu, 30 Apr 2015 15:08:16 GMT
 (envelope-from daemon-user@phabric-backend.isc.freebsd.org)
Received: (from daemon-user@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3UF8GcW051177;
 Thu, 30 Apr 2015 15:08:16 GMT (envelope-from daemon-user)
Date: Thu, 30 Apr 2015 15:08:16 +0000
To: freebsd-toolchain@freebsd.org
From: "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2408: Add ELF Tool Chain's c++filt to
 the build
Message-ID: <7fe93998747d1c634c8b04c67f88ff09@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2408: Add ELF Tool Chain's c++filt to the build
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-3zbfu5k56ia67kimqhps>
X-Phabricator-Cc: <PHID-MLST-i5ptaleg3lqtvx7cknno>
In-Reply-To: <differential-rev-PHID-DREV-p3szawadf7l7266bqfgt-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-p3szawadf7l7266bqfgt-req@FreeBSD.org>
Thread-Index: NTlmNTU4Y2I5N2RjNDEwM2E5OWYxY2VlZTc3IFVCRWA=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2015 15:08:17 -0000

emaste added a comment.

Oh - we also need either:

  diff --git a/gnu/usr.bin/cc/Makefile b/gnu/usr.bin/cc/Makefile
  index abc9876..12ee7f8 100644
  --- a/gnu/usr.bin/cc/Makefile
  +++ b/gnu/usr.bin/cc/Makefile
  @@ -12,7 +12,10 @@ SUBDIR+= cpp
   .endif
   
   .if ${MK_CXX} != "no"
  -SUBDIR+= cc1plus c++ c++filt
  +SUBDIR+= cc1plus c++
  +.if ${MK_ELFTOOLCHAIN_TOLOLS} != "no"
  +SUBDIR+= c++filt
  +.endif
   .endif
   
   .if ${MK_GCOV} != "no"

or

  --- a/usr.bin/Makefile
  +++ b/usr.bin/Makefile
  @@ -238,7 +238,9 @@ SUBDIR+=    ee
   
   .if ${MK_ELFTOOLCHAIN_TOOLS} != "no"
   _addr2line=    addr2line
  +.if ${MK_GCC} != "no" && ${MK_CXX} != "no"
   _cxxfilt=      cxxfilt
  +.endif
   _elfcopy=      elfcopy
   _nm=           nm
   _readelf=      readelf


REVISION DETAIL
  https://reviews.freebsd.org/D2408

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: emaste, brooks
Cc: freebsd-toolchain