From owner-freebsd-fs@FreeBSD.ORG Thu Feb 25 10:32:54 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3FFA8106564A for ; Thu, 25 Feb 2010 10:32:54 +0000 (UTC) (envelope-from ndenev@gmail.com) Received: from mail-fx0-f223.google.com (mail-fx0-f223.google.com [209.85.220.223]) by mx1.freebsd.org (Postfix) with ESMTP id C128C8FC1A for ; Thu, 25 Feb 2010 10:32:53 +0000 (UTC) Received: by fxm23 with SMTP id 23so610567fxm.3 for ; Thu, 25 Feb 2010 02:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:message-id:references:to :x-mailer; bh=PGJGpnadWLdPYAudmBKcF9gNpEPvxBKfFqNeSy2aelM=; b=UxiBS4grQDE1QVBu1+1A6ARl34IMUn4r/wpglwax80Csp2j1CTEV3I8evmFD6/Iz1c iZKmaNVjgKuX5zWk8kM0q5EiIOEAMWP1qHq2cBFrlMExbzS20JeaMsi2eNwXqKPrhruu fLV1t+KvSnq2siFf75pU4HT3a11kng6g6LG+k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to:x-mailer; b=DLp0bMqy3xE8lmqTsRJP0IWpCAEAaBwf91AQKLeDkhIvWMPtnfNtkIvaX21PMkmu8q NR+hm4d8Gya7jzE0yRWTRQ8DF2pXpw+SvfHbB5epj+bvhaAoJdxCeQcnD+v11fIUNr9W 1FnwMXOs2vUfWdEbGvSn4WoRgd2+/nYPedfS8= Received: by 10.103.86.17 with SMTP id o17mr731335mul.47.1267093967592; Thu, 25 Feb 2010 02:32:47 -0800 (PST) Received: from ?10.32.23.105? ([195.34.111.178]) by mx.google.com with ESMTPS id 7sm13598705mup.3.2010.02.25.02.32.45 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 25 Feb 2010 02:32:46 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: multipart/mixed; boundary=Apple-Mail-6-1023955540 From: Nikolay Denev In-Reply-To: <4B8649F4.4070303@omnilan.de> Date: Thu, 25 Feb 2010 12:32:44 +0200 Message-Id: <1C136B0A-E98F-4F93-8480-7FACD3FE4E4B@gmail.com> References: <4B8649F4.4070303@omnilan.de> To: Harald Schmalzbauer X-Mailer: Apple Mail (2.1077) Cc: freebsd-fs@freebsd.org Subject: Re: ZFS write stalls (starving reads) and tuning zfs_write_limit_override X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2010 10:32:54 -0000 --Apple-Mail-6-1023955540 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Feb 25, 2010, at 11:59 AM, Harald Schmalzbauer wrote: > Hello, >=20 > I found your very interesting patch: = http://lists.freebsd.org/pipermail/freebsd-fs/2010-February/007818.html > Unfortunately it seems to be -current since on -stable my dsl_pool.c = looks entire different. > My C skills don't allow me to adopt. Do you have any hints for me? >=20 > Thanks, >=20 > -Harry >=20 Hi, What I posted was not a patch, but just the lines need to be added to = dsl_pool.c and it should work for either 8 or CURRENT. Here is a patch for 8-STABLE that I just generated, can you try that one = (pasting in the email in case the email eats the attachment= --Apple-Mail-6-1023955540 Content-Disposition: attachment; filename=zfs_write_limit_override.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="zfs_write_limit_override.patch" Content-Transfer-Encoding: 7bit --- .zfs/snapshot/orig/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c 2009-08-24 07:30:23.677549074 +0300 +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c 2010-02-19 09:17:50.058020997 +0200 @@ -47,6 +47,11 @@ uint64_t zfs_write_limit_override = 0; extern uint64_t zfs_write_limit_min; +SYSCTL_DECL(_vfs_zfs); +TUNABLE_ULONG("vfs.zfs.write_limit_override", &zfs_write_limit_override); +SYSCTL_ULONG(_vfs_zfs, OID_AUTO, zfs_write_limit_override, CTLFLAG_RW, &zfs_write_limit_override, 0, + "Override maximum TXG size"); + kmutex_t zfs_write_limit_lock; static pgcnt_t old_physmem = 0; --Apple-Mail-6-1023955540 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii ): --- = .zfs/snapshot/orig/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool= .c 2009-08-24 07:30:23.677549074 +0300 +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c = 2010-02-19 09:17:50.058020997 +0200 @@ -47,6 +47,11 @@ uint64_t zfs_write_limit_override =3D 0; extern uint64_t zfs_write_limit_min; =20 +SYSCTL_DECL(_vfs_zfs); +TUNABLE_ULONG("vfs.zfs.write_limit_override", = &zfs_write_limit_override); +SYSCTL_ULONG(_vfs_zfs, OID_AUTO, zfs_write_limit_override, CTLFLAG_RW, = &zfs_write_limit_override, 0, + "Override maximum TXG size"); + kmutex_t zfs_write_limit_lock; =20 static pgcnt_t old_physmem =3D 0; Regards, Niki Denev --Apple-Mail-6-1023955540--