From owner-freebsd-bugs Mon Aug 28 15:30: 5 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 715E137B43C for ; Mon, 28 Aug 2000 15:30:03 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id PAA30241; Mon, 28 Aug 2000 15:30:03 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Mon, 28 Aug 2000 15:30:03 -0700 (PDT) Message-Id: <200008282230.PAA30241@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: volf@oasis.IAEhv.nl (Frank Volf) Subject: Re: kern/20877: ICMP error msg on UDP port unreachable is incorrect Reply-To: volf@oasis.IAEhv.nl (Frank Volf) Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR kern/20877; it has been noted by GNATS. From: volf@oasis.IAEhv.nl (Frank Volf) To: Ruslan Ermilov Cc: Frank Volf , bug-followup@FreeBSD.org, Garrett Wollman , Sheldon Hearn Subject: Re: kern/20877: ICMP error msg on UDP port unreachable is incorrect Date: Tue, 29 Aug 2000 00:17:04 +0200 (CEST) Ruslan Ermilov wrote: > On Sun, Aug 27, 2000 at 07:45:22PM +0200, Frank Volf wrote: > > > > I disagree with the fact that you simply close this pr as being a duplicate > > case of PR 16240. > > > > PR 16240 tries to address the generic problem, which is indeed present in > > many network implementations and may or maynot be difficult to fix. > > > > Here, a very simple patch is presented for a special instance of 16240 > > (an instance that occurs a lot, e.g. using udp based tracerouted). I see no > > reason why this patch cannot be applied to FreeBSD. > > > The reason is simple -- your patch is wrong and incomplete. I agree that I overlooked the ip_off part. At the place where I inserted my patch the packet is reassambled so ip_off must be zero. But I forgot about the MF and DF flags that could be set, and therefore my patch does not work for that case. Sorry for that. I'll try your patch and see how it works. Thanks, Frank To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message