Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Dec 2017 02:15:35 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 224354] [PATCH] graphics/imlib2: fix X11 dependency (again)
Message-ID:  <bug-224354-13@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224354

            Bug ID: 224354
           Summary: [PATCH] graphics/imlib2: fix X11 dependency (again)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: zeising@FreeBSD.org
          Reporter: dominik@honnef.co
          Keywords: patch
             Flags: maintainer-feedback?(zeising@FreeBSD.org)
          Assignee: zeising@FreeBSD.org

Created attachment 188849
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D188849&action=
=3Dedit
imlib2 patch fixing --without-x11 builds

When imlib2 is built without support for X11, Imlib2.h #includes X11/Xlib.h
conditionally, guarded by an #ifndef X_DISPLAY_MISSING =E2=80=93 X_DISPLAY_=
MISSING,
however, isn't set, causing Imlib2.h to unsuccessfully include the header. =
This
was previously addressed in bug #187147 by patching Imlib2.h, but the patch
isn't working anymore, for two reasons.

1) When the Makefile was updated to use the new, conditional version of
post-patch, the condition was accidentally negated, applying the patch only
when imlib2 was being built *with* X11 support (bug #210609)

2) Whitespace around the macros in Imlib2.h changed.

The attached patch fixes both.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-224354-13>