From owner-cvs-all@FreeBSD.ORG Thu Mar 6 09:45:17 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FF171065674 for ; Thu, 6 Mar 2008 09:45:17 +0000 (UTC) (envelope-from yar.tikhiy@gmail.com) Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.185]) by mx1.freebsd.org (Postfix) with ESMTP id F2B098FC13 for ; Thu, 6 Mar 2008 09:45:16 +0000 (UTC) (envelope-from yar.tikhiy@gmail.com) Received: by rv-out-0910.google.com with SMTP id g13so1381674rvb.43 for ; Thu, 06 Mar 2008 01:45:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=qP4kkw2kWLrM2WHN4GLykS5vaGdgM94yDQ/qsYd35UM=; b=rk5gxhlxzUA2oZuXtIgDQsk1aaMDKLzb66WB/hQ9iYCNA5fnsu4ibxNnYSyfNoJe3QEIox/QI0ctC8p/kP4CskmfGUfyBD6leWpTBNEJechr/WtQFkdx9g9XM3pUc6hpSf6rfy8zguT7GCs5claDPaFr6kSvnd1Wl6u5U247JSo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=B5HIyPpFNsCTAG/RlHdaMLJymcMAfghMPaOF4UTQ3+mobnBLXYLZLhTT7BaWZm9WecqZ0z1NQzCLwatULzAmByIMwZ8Ag4jwORJMRrLdZGguIvw/TJ7uzgZqraIBhZqc56DtaKWRgRQTv/k2MhJBKstM+n8Nmm9DZd3cN1xQF9s= Received: by 10.141.50.17 with SMTP id c17mr1868906rvk.191.1204796716638; Thu, 06 Mar 2008 01:45:16 -0800 (PST) Received: by 10.141.52.1 with HTTP; Thu, 6 Mar 2008 01:45:16 -0800 (PST) Message-ID: Date: Thu, 6 Mar 2008 12:45:16 +0300 From: "Yar Tikhiy" Sender: yar.tikhiy@gmail.com To: "Jung-uk Kim" In-Reply-To: <200803052143.48208.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803060214.m262EjmG032525@repoman.freebsd.org> <53687.192.168.4.151.1204770665.squirrel@router> <200803052143.48208.jkim@FreeBSD.org> X-Google-Sender-Auth: dcfa4f692c68f380 Cc: Max Laier , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/moused moused.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Mar 2008 09:45:17 -0000 On Thu, Mar 6, 2008 at 5:43 AM, Jung-uk Kim wrote: > On Wednesday 05 March 2008 09:31 pm, Max Laier wrote: > > Am Do, 6.03.2008, 03:14, schrieb Jung-uk Kim: > > > jkim 2008-03-06 02:14:45 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > usr.sbin/moused moused.c > > > Log: > > > Cast time_t to long to mute tinderbox build failure. > > > > doesn't this defeat the purpose of having time_t in the first > > place? I'd rather cast to intmax_t and print with %j ... though > > it probably doesn't matter. > > Now the timestamp is uptime and the breakage was just debugging > output, it shouldn't really matter at all but I will do that soon. Yes it matters because it has to do with everyday coding practice. It is one of small yet important advances in C99 that we can now printf non-basic integral types _portably_[1] and _reliably_ through %j[du] and a cast to [u]intmax_t. [1] Well, almost portably as we need to guess the signedness of the type. -- Yar