From owner-freebsd-stable@FreeBSD.ORG Tue Sep 3 14:02:37 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 27B64272 for ; Tue, 3 Sep 2013 14:02:37 +0000 (UTC) (envelope-from nonesuch@longcount.org) Received: from mail-qa0-f51.google.com (mail-qa0-f51.google.com [209.85.216.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DB9A82ED1 for ; Tue, 3 Sep 2013 14:02:36 +0000 (UTC) Received: by mail-qa0-f51.google.com with SMTP id bv4so1301578qab.3 for ; Tue, 03 Sep 2013 07:02:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=+nu+cBTt5m7UlROak97RWGLnY5IKAK4R5EO3Dgd7co4=; b=aBn4CX3o39QFdWf1oekfPR7JZLF3MLi7UIXEUZu9xortq1TGpJXEQSFB93EtkwJoJx jqq5omxC09ZNRm7a9Xa6PzSN2TMGE/Dtm2d7t5Re9coLqSpsTDx64vdWYZokUD+n1Q0w taT6pA2Y2uYq4AT/lJtoXF0goSBy25gW1br5icZtOD5/4VhQNYoRhz5IkfXJuzObw56r C0JJV9fZX+CyJ4rTpEy/Kvmexbjzi1eazq81d/pkmoeabezeaOOoMlSM8r6zcCf9OD6N ug3anLITEkMNX1XLL/ulmbi/14lXBR97KOvvAbnBK1cM507eSJe4UyUrvhV5xNA7QHYH Lh7A== X-Gm-Message-State: ALoCoQks3noL13vpJEuNmKQW7u29nDFSgxcZWXGE2UAWH0pN34DXgE26WockEn37uctVDQdL6p3O X-Received: by 10.49.121.134 with SMTP id lk6mr7733690qeb.23.1378216949846; Tue, 03 Sep 2013 07:02:29 -0700 (PDT) Received: from [97.165.13.201] (201.sub-97-165-13.myvzw.com. [97.165.13.201]) by mx.google.com with ESMTPSA id m5sm26191478qaa.13.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Sep 2013 07:02:29 -0700 (PDT) References: <201308311738.r7VHcnRR021632@svn.freebsd.org> Mime-Version: 1.0 (1.0) In-Reply-To: <201308311738.r7VHcnRR021632@svn.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: X-Mailer: iPhone Mail (10B329) From: Mark Saad Subject: Re: svn commit: r255104 - stable/9/sys/ufs/ufs Date: Tue, 3 Sep 2013 10:02:25 -0400 To: Kirk McKusick Cc: freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 14:02:37 -0000 Kirk Will this be merged into 9.2-RC? Before the Release ? =20 --- Mark saad | mark.saad@longcount.org On Aug 31, 2013, at 1:38 PM, Kirk McKusick wrote: > Author: mckusick > Date: Sat Aug 31 17:38:49 2013 > New Revision: 255104 > URL: http://svnweb.freebsd.org/changeset/base/255104 >=20 > Log: > MFC of 253998: >=20 > This bug fix is in a code path in rename taken when there is a > collision between a rename and an open system call for the same > target file. Here, rename releases its vnode references, waits for > the open to finish, and then restarts by reacquiring its needed > vnode locks. In this case, rename was unlocking but failing to > release its reference to one of its held vnodes. The effect was > that even after all the actual references to the vnode had gone, > the vnode still showed active references. For files that had been > removed, their space was not reclaimed until the filesystem was > forcibly unmounted. >=20 > This bug manifested itself in the Postgres server which would > leak/lose hundreds of files per day amounting to many gigabytes of > disk space. This bug required shutting down Postgres, forcibly > unmounting its filesystem, remounting its filesystem and restarting > Postgres every few days to recover the lost space. >=20 > Reported by: Dan Thomas and Palle Girgensohn > Bug-fix by: kib > Tested by: Dan Thomas and Palle Girgensohn >=20 > Modified: > stable/9/sys/ufs/ufs/ufs_vnops.c > Directory Properties: > stable/9/sys/ (props changed) >=20 > Modified: stable/9/sys/ufs/ufs/ufs_vnops.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- stable/9/sys/ufs/ufs/ufs_vnops.c Sat Aug 31 17:33:25 2013 (r2551= 03) > +++ stable/9/sys/ufs/ufs/ufs_vnops.c Sat Aug 31 17:38:49 2013 (r2551= 04) > @@ -1271,7 +1271,7 @@ relock: > error =3D VFS_VGET(mp, ino, LK_EXCLUSIVE, &nvp); > if (error !=3D 0) > goto releout; > - VOP_UNLOCK(nvp, 0); > + vput(nvp); > atomic_add_int(&rename_restarts, 1); > goto relock; > } > _______________________________________________ > svn-src-stable-9@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-stable-9 > To unsubscribe, send any mail to "svn-src-stable-9-unsubscribe@freebsd.org= "