From owner-freebsd-current@FreeBSD.ORG  Wed May  7 12:45:05 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0CDA237B404
	for <current@freebsd.org>; Wed,  7 May 2003 12:45:05 -0700 (PDT)
Received: from mail26b.sbc-webhosting.com (mail26b.sbc-webhosting.com
	[216.173.237.165])
	by mx1.FreeBSD.org (Postfix) with SMTP id CE8EB43FA3
	for <current@freebsd.org>; Wed,  7 May 2003 12:45:03 -0700 (PDT)
	(envelope-from alc@imimic.com)
Received: from www.imimic.com (64.143.12.21)3-0414096698;
	Wed,  7 May 2003 15:44:59 -0400 (EDT)
Sender: alc@FreeBSD.ORG
Message-ID: <3EB9623C.94365A8F@imimic.com>
Date: Wed, 07 May 2003 14:45:00 -0500
From: "Alan L. Cox" <alc@imimic.com>
Organization: iMimic Networking, Inc.
X-Mailer: Mozilla 4.8 [en] (X11; U; Linux 2.4.2 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Ian Dowse <iedowse@maths.tcd.ie>
References: <200305030537.ab79568@salmon.maths.tcd.ie>
Content-Type: text/plain; charset=x-user-defined
Content-Transfer-Encoding: 7bit
X-Loop-Detect: 1
cc: mckusick@mckusick.com
cc: Jeff Roberson <jroberson@chesapeake.net>
cc: Scott Long <scott_long@btc.adaptec.com>
cc: current@freebsd.org
cc: alc@freebsd.org
Subject: Re: Panic in ffs_blkfree()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 May 2003 19:45:05 -0000

Ian Dowse wrote:
> 
> In message <3EB2FB35.8060104@btc.adaptec.com>, Scott Long writes:
> >Kirk and all,
> >
> >Recently a panic started appearing on mine and other's systems while
> >under  load.  I have an SMP system with all UFS1+softupdates
> 
> Try reverting revisions sys/vm/vm_object.c 1.274 and kern/vfs_subr.c
> revision 1.444, i.e. apply the patch below. I think there may be
> cases where the `all' flag was necessary; instrumentation of
> vm_object_page_remove() in a kernel from Apr 5th shows cases where
> pages with both wrapped negative (indirection blocks I presume) and
> larger than object->size page indices get selected, so this would
> have been broken by limiting the range to < object->size.
> 

Please take a look at vm_object_page_clean().  If end == 0, it relies on
object->size to determine the extent of the pages for cleaning.  In
light of the above, particularly, the positive indices, we should be
worried that msync is skipping pages.

Alan