From owner-cvs-src@FreeBSD.ORG  Sat Jun 11 08:24:47 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 732F016A41C;
	Sat, 11 Jun 2005 08:24:47 +0000 (GMT)
	(envelope-from flata@magnesium.net)
Received: from toxic.magnesium.net (toxic.magnesium.net [207.154.84.15])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3A3C643D49;
	Sat, 11 Jun 2005 08:24:47 +0000 (GMT)
	(envelope-from flata@magnesium.net)
Received: by toxic.magnesium.net (Postfix, from userid 1212)
	id 0E1CADA8A4; Sat, 11 Jun 2005 01:24:47 -0700 (PDT)
Date: Fri, 10 Jun 2005 22:24:47 -1000
From: juli mallett <jmallett@FreeBSD.org>
To: Brian Fundakowski Feldman <green@freebsd.org>
Message-ID: <20050611082446.GA54459@toxic.magnesium.net>
References: <200506102350.j5ANofFM008212@repoman.freebsd.org>
	<20050611034930.GY17867@elvis.mu.org>
	<20050611064956.GC66188@green.homeunix.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050611064956.GC66188@green.homeunix.org>
User-Agent: Mutt/1.4.1i
X-Towel: Yes
Cc: cvs-src@freebsd.org, alfred@freebsd.org, cvs-all@freebsd.org,
	src-developers@freebsd.org
Subject: Re: cvs commit: src/sys/nfsclient nfs_bio.c nfs_vfsops.c nfsargs.h
	nfsmount.h src/sys/sys buf.h bufobj.h src/sys/kern vfs_bio.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Jun 2005 08:24:47 -0000

* Brian Fundakowski Feldman <green@freebsd.org> [ Date: 2005-06-10 ]
	[ w.r.t. Re: cvs commit: src/sys/nfsclient nfs_bio.c nfs_vfsops.c nfsargs.h nfsmount.h src/sys/sys buf.h bufobj.h src/sys/kern vfs_bio.c ]
> On Fri, Jun 10, 2005 at 08:49:30PM -0700, Alfred Perlstein wrote:
> > Returning EAGAIN from a disk IO seems bogus, are you sure it makes
> > sense to do that when IO_NDELAY is set?  Shouldn't it just be ignored
> > like other FSes do?
> 
> Well, it's not disk IO, it's network IO.  I figure if you set that
> flag you should expect commensurate error return values.  This is
> conceivably a useful behavior, and POSIX does not forbid it, so I just
> made the judgement call to not deny the functionality.
> 
> Would you actually be surprised to get EAGAIN if you requested
> non-blocking access to a file stream, ignoring the fact that it just
> happens to not have been done already for other S_ISREG file streams?

There's a surprisingly good email from Terry about this here:
http://lists.freebsd.org/pipermail/freebsd-current/2003-April/000356.html

In short, green wins.