From owner-freebsd-hackers@freebsd.org Fri Jul 3 22:52:45 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01D5F994D14 for ; Fri, 3 Jul 2015 22:52:45 +0000 (UTC) (envelope-from max@m00nbsd.net) Received: from 10.mo3.mail-out.ovh.net (10.mo3.mail-out.ovh.net [87.98.165.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BC0282D9B for ; Fri, 3 Jul 2015 22:52:44 +0000 (UTC) (envelope-from max@m00nbsd.net) Received: from mail404.ha.ovh.net (gw6.ovh.net [213.251.189.206]) by mo3.mail-out.ovh.net (Postfix) with SMTP id 48BF4FF93F9 for ; Fri, 3 Jul 2015 18:55:17 +0200 (CEST) Received: from localhost (HELO queueout) (127.0.0.1) by localhost with SMTP; 3 Jul 2015 18:55:16 +0200 Received: from str75-4-78-193-192-205.fbxo.proxad.net (HELO localhost.localdomain) (max@M00nBSD.net@78.193.192.205) by ns0.ovh.net with SMTP; 3 Jul 2015 18:55:15 +0200 Message-ID: <5596BE6B.8030508@m00nbsd.net> Date: Fri, 03 Jul 2015 18:55:07 +0200 From: Maxime Villard MIME-Version: 1.0 To: Pedro Giffuni CC: FreeBSD Hackers Subject: Re: Brainy: Set of 17 potential bugs References: <5596B894.5060708@FreeBSD.org> In-Reply-To: <5596B894.5060708@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 13723312490244607963 X-Ovh-Remote: 78.193.192.205 (str75-4-78-193-192-205.fbxo.proxad.net) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeekvddrfeehucetufdoteggucfrrhhofhhilhgvmecuqfggjfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeekvddrfeehucetufdoteggucfrrhhofhhilhgvmecuqfggjfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2015 22:52:45 -0000 Le 03/07/2015 18:30, Pedro Giffuni a écrit : > Hi Maxime; > > Le 28/02/2015 15:51, Maxime Villard a écrit : >> Hi, >> I have been developing a C code scanner for a while, particularly good at >> finding kernel bugs. I've scanned the FreeBSD tree partially, and among >> the numerous results, I've put here a list of 17 bugs affecting the >> FreeBSD-10 Stable kernel: >> >> http://m00nbsd.net/59a47a86959c23b3f7c8bc495598dfde.html > > I think: > # 04 SYS/NFS/ > > _01/FIXED-rev279405|UNINITIALIZED VAR: krpc_subr.crev256281 > > Uninitialized var 'so' at l.430. > > is a false positive. > > The socket is created on line 222. > I guess you didn't spot the "FIXED-rev279405" mentioned in the line you just quoted. Fixed four months ago: http://svnweb.freebsd.org/base/head/sys/nfs/krpc_subr.c?view=log Maxime