From owner-freebsd-hackers@FreeBSD.ORG  Sun Jan 11 09:50:32 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 019E816A4CE; Sun, 11 Jan 2004 09:50:32 -0800 (PST)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4AE0443D3F; Sun, 11 Jan 2004 09:50:30 -0800 (PST)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.10/8.12.10) with ESMTP id i0BHmuUd001696;
	Sun, 11 Jan 2004 12:48:56 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i0BHmuNI001693;
	Sun, 11 Jan 2004 12:48:56 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Date: Sun, 11 Jan 2004 12:48:56 -0500 (EST)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
In-Reply-To: <20040111155842.GB74246@garage.freebsd.pl>
Message-ID: <Pine.NEB.3.96L.1040111124747.91469c-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-hackers@freebsd.org
cc: phk@freebsd.org
Subject: Re: MD(4) cleanups and unload lesson.
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Jan 2004 17:50:32 -0000


On Sun, 11 Jan 2004, Pawel Jakub Dawidek wrote:

> With attached patch unloading md(4) module is possible.  It also cleans
> up big part of code according to style(9). 

Could you separate this into a functional diff and a style diff?  There's
a general preference to not combine them, as it means cvs diff between
revisions isn't useful for identifying functional changes (i.e., reviewing
for bugs when back-tracking, etc). 

Thanks,

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Senior Research Scientist, McAfee Research