Date: Wed, 26 Jun 2013 10:10:21 -0700 (PDT) From: Greg Lewis <glewis@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/180005: DOS2UNIX doesn't print out the files it's converting Message-ID: <201306261710.r5QHALuL084323@misty.eyesbeyond.com> Resent-Message-ID: <201306261720.r5QHK2QF069316@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 180005
>Category: ports
>Synopsis: DOS2UNIX doesn't print out the files it's converting
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 26 17:20:02 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Greg Lewis
>Release: FreeBSD 8.4-RELEASE i386
>Organization:
FreeBSD Project
>Environment:
System: FreeBSD misty.eyesbeyond.com 8.4-RELEASE FreeBSD 8.4-RELEASE #0 r250991: Sat May 25 14:12:15 PDT 2013 root@misty.eyesbeyond.com:/usr/obj/usr/src/sys/MISTY i386
>Description:
When using the USE_DOS2UNIX macro, the message printed out doesn't
include the file name. The intention of the code appears to be
that the file name should be included.
>How-To-Repeat:
Build java/openjdk7. Near the start of the build you'll see the
output:
===> Converting DOS text file to UNIX text file:
Note the lack of anything after the colon.
>Fix:
Index: bsd.port.mk
===================================================================
--- bsd.port.mk (revision 321581)
+++ bsd.port.mk (working copy)
@@ -3570,9 +3570,9 @@
${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/
$$//'
.else
- @${ECHO_MSG} "===> Converting DOS text file to UNIX text file: ${f}"
.if ${USE_DOS2UNIX:M*/*}
.for f in ${USE_DOS2UNIX}
+ @${ECHO_MSG} "===> Converting DOS text file to UNIX text file: ${f}"
@${REINPLACE_CMD} -i '' -e 's/
$$//' ${WRKSRC}/${f}
.endfor
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306261710.r5QHALuL084323>