From nobody Fri Aug 15 20:36:20 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c3YmN2rZTz64Gwj; Fri, 15 Aug 2025 20:36:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c3YmN1v0tz3TQ5; Fri, 15 Aug 2025 20:36:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755290180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hkZvqCDhJwK4IdmuYxU7CtcBEmVOHswNLMezFl8AHZQ=; b=FFUssK1qf5d3gKOILUYMcEkaeaY5mLSvwiLyDKNrYKpyxn8ZcqNu4B5VBP54hPyPGG77Kb Jbc0gcz1yklQ3Y6mu8Ua2OuNqZho/WMF8wSmArmBJhA9Nk+6OS/FKGpWG1ekWS3pBIgr42 LHZtpo461pBq+cJgizjthMLoUCltB1B7roJG0Uu4dJ++Y862BxS6DTp7AsI6lqm2vTDDX0 MwFcv82XJpkbhjXvwz44m1mR3w9CTCMnlNAfKSsiIpeRzViTLO4Ea6OYA6FzvrsU3bGfX/ Drb/vutiYhpQX7OLNGt5cX2y46qwUcFQAbA+Ujmu76/MOSMUdSWrmMsCsLZZ1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755290180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hkZvqCDhJwK4IdmuYxU7CtcBEmVOHswNLMezFl8AHZQ=; b=hcjYO9uNlhnYzTSyxkdGchtWuAw+IB5orl5HRIW1zP1Yy1K5luU0R8FR4DClqPkL68n5lW zrJlaIqDVakjgbsSOYqvAmeukzL+jXbT2BAbvPd6Y8qumIr4ES8U8ZiNXazQrQtuOighIs 8IBwGAEdsih6wyO/uLwnmZ6uXoZVnoKEzWIFeqzIVCIRQPv6N6JMkcAIctt3c2M4JJFVgA 8H5USP4tGbZFIjS0VJQgjGPBSkmndXUrvyu7t9NqMRuUCZvDrnjZlSUufjuJSUGQ8dox3H CVWGeMV7k3oiGyBpjTSNDLqaQmFt5q25DXy5u8j2E1mlGgPJAiYKuXeW8ZwcRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755290180; a=rsa-sha256; cv=none; b=QWrmmbv8dfi7DHuaqvkhQADWuR1kiHL5t9ZzxdO808A07pBA+bQLU2h26BDYCHLtUvXLTX w4rZUl3M8k9iGZ0avcrRazgkBCSRmNGIIandrYE64QnAc7SHf5yEQSC7UMjd3E+V4n+OUd F7aMxIoMyftBZlag7dfEIdKOA4RXnFcWMxXPC6A7FDEt5EYmIszHuqqyMu+esWPMRh7b2T UT/SBaK24bU5vJJ6C2zMVZw/Bc53PV1NzNLSBFfK5hhGqZXU+8/NQtXvv6LsoonLJilLbY 4YAOHLTYaV61qi9WFqeTBj285K2VmHMc/Ivb9lclgpAbjvgS6qsds+vzgGTKvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c3YmN1HjLzt55; Fri, 15 Aug 2025 20:36:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57FKaKa0092225; Fri, 15 Aug 2025 20:36:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57FKaKA0092222; Fri, 15 Aug 2025 20:36:20 GMT (envelope-from git) Date: Fri, 15 Aug 2025 20:36:20 GMT Message-Id: <202508152036.57FKaKA0092222@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eric van Gyzen Subject: git: 9a7c512a6149 - main - ucred groups: restore a useful comment List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vangyzen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9a7c512a614993333beec4e2d509290b0c00dde6 Auto-Submitted: auto-generated The branch main has been updated by vangyzen: URL: https://cgit.FreeBSD.org/src/commit/?id=9a7c512a614993333beec4e2d509290b0c00dde6 commit 9a7c512a614993333beec4e2d509290b0c00dde6 Author: Eric van Gyzen AuthorDate: 2025-08-15 13:16:58 +0000 Commit: Eric van Gyzen CommitDate: 2025-08-15 13:29:18 +0000 ucred groups: restore a useful comment The most useful comments are those that explain _why_. Restore such an explanation dropped by commit 6d2efbb34fd. Reviewed by: kevans Sponsored by: Dell Inc. Differential Revision: https://reviews.freebsd.org/D51918 --- sys/kern/kern_prot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index dac0e40b0599..0ca42d640767 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -2921,7 +2921,8 @@ crextend(struct ucred *cr, int n) * Normalizes a set of groups to be applied to a 'struct ucred'. * * Normalization ensures that the supplementary groups are sorted in ascending - * order and do not contain duplicates. + * order and do not contain duplicates. This allows group_is_supplementary + * to do a binary search. */ static void groups_normalize(int *ngrp, gid_t *groups)