From owner-cvs-all@FreeBSD.ORG  Tue Feb 14 21:55:16 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1AF6416A422;
	Tue, 14 Feb 2006 21:55:16 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CBC0F43D45;
	Tue, 14 Feb 2006 21:55:15 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k1ELtFRF043007;
	Tue, 14 Feb 2006 21:55:15 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k1ELtFFb043006;
	Tue, 14 Feb 2006 21:55:15 GMT (envelope-from rwatson)
Message-Id: <200602142155.k1ELtFFb043006@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Tue, 14 Feb 2006 21:55:15 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: RELENG_6
Cc: 
Subject: cvs commit: src/sys/netncp ncp_conn.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Feb 2006 21:55:16 -0000

rwatson     2006-02-14 21:55:15 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/netncp           ncp_conn.c 
  Log:
  Merge ncp_conn.c:1.28 from HEAD to RELENG_6:
  
    In ncp_sysctl_connstat(), the SLIST_FOREACH() logic to check 'error'
    resulted in deadcode, as 'error' could never be 0.  What this logic
    was originally meant to handle is not clear -- it's been this way
    (broken) since at least RELENG_4.
  
    Found with:     Coverity Prevent(tm)
  
  Approved by:    re (scottl)
  
  Revision  Changes    Path
  1.26.2.1  +1 -7      src/sys/netncp/ncp_conn.c