From owner-cvs-all@FreeBSD.ORG  Wed Mar 24 01:00:45 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BFA9C16A4CE; Wed, 24 Mar 2004 01:00:45 -0800 (PST)
Received: from VARK.homeunix.com (adsl-69-104-80-69.dsl.pltn13.pacbell.net
	[69.104.80.69])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 977C443D31; Wed, 24 Mar 2004 01:00:45 -0800 (PST)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.homeunix.com (localhost [127.0.0.1])
	by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i2O90ak8061594;
	Wed, 24 Mar 2004 01:00:36 -0800 (PST)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i2O90axE061593;
	Wed, 24 Mar 2004 01:00:36 -0800 (PST)
	(envelope-from das@FreeBSD.ORG)
Date: Wed, 24 Mar 2004 01:00:36 -0800
From: David Schultz <das@FreeBSD.ORG>
To: "David O'Brien" <obrien@FreeBSD.ORG>
Message-ID: <20040324090036.GA61340@VARK.homeunix.com>
Mail-Followup-To: David O'Brien <obrien@FreeBSD.ORG>,
	Nate Lawson <nate@root.org>, cvs-all@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG
References: <20040322223625.430EF16A4F2@hub.freebsd.org>
	<20040322180452.A35931@root.org> <20040323025048.GA46675@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040323025048.GA46675@dragon.nuxi.com>
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
cc: Nate Lawson <nate@root.org>
Subject: Re: cvs commit: src/sys/kern subr_bus.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Mar 2004 09:00:45 -0000

On Mon, Mar 22, 2004, David O'Brien wrote:
> On Mon, Mar 22, 2004 at 06:06:48PM -0800, Nate Lawson wrote:
> > > +			if (bootverbose && flags & INTR_MPSAFE)
> .. 
> > I recommend you parenthesize (flags & INTR_MPSAFE).
> 
> man operator  :-)

For some reason, gcc complains about the lack of excessive
parentheses for expressions like 'a && b || c' and
'foo >> shift1 + shift2', but not for 'a && b & c'.
It's too bad there's no documentation on which parts of
operator(7) are supposed to be considered obvious (along
with a note that =='s priority over & is a mistake---that
one often bites me.)