From owner-dev-commits-src-main@freebsd.org Fri Feb 26 17:36:31 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 66BA65482EC; Fri, 26 Feb 2021 17:36:31 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnGzg2TB4z4cH7; Fri, 26 Feb 2021 17:36:31 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (ns393929.ip-176-31-115.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 2E1012CF3; Fri, 26 Feb 2021 17:36:31 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id D196B36215; Fri, 26 Feb 2021 18:36:29 +0100 (CET) Date: Fri, 26 Feb 2021 18:36:29 +0100 From: Baptiste Daroussin To: rgrimes@freebsd.org Cc: Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database Message-ID: <20210226173629.2sc6wlaasxjep3le@aniel.nours.eu> References: <202102261420.11QEKJoX006569@slippy.cwsent.com> <202102261730.11QHUh8n031156@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v42fwzf6tezfxlhv" Content-Disposition: inline In-Reply-To: <202102261730.11QHUh8n031156@gndrsh.dnsmgr.net> X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 17:36:31 -0000 --v42fwzf6tezfxlhv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 26, 2021 at 09:30:43AM -0800, Rodney W. Grimes wrote: > > In message <202102251327.11PDR4eC083842@gitrepo.freebsd.org>, Baptiste= =20 > > Daroussi > > n writes: > > > The branch main has been updated by bapt: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D2a50a9de8340f08bd876e9= e5993332ae > > > 14376f80 > > > > > > commit 2a50a9de8340f08bd876e9e5993332ae14376f80 > > > Author: Baptiste Daroussin > > > AuthorDate: 2021-02-23 16:17:32 +0000 > > > Commit: Baptiste Daroussin > > > CommitDate: 2021-02-25 13:25:32 +0000 > > > > > > terminfo: add terminfo database > > > =20 > > > Tested by: manu, jbeich > > > --- > > > share/Makefile | 1 + > > > share/terminfo/Makefile | 34 ++++++++++++++++++++++++++++++++++ > > > 2 files changed, 35 insertions(+) > > > > > > diff --git a/share/Makefile b/share/Makefile > > > index c4e12b05f7db..d6854b230ae5 100644 > > > --- a/share/Makefile > > > +++ b/share/Makefile > > > @@ -26,6 +26,7 @@ SUBDIR=3D ${_colldef} \ > > > ${_syscons} \ > > > tabset \ > > > termcap \ > > > + terminfo \ > > > ${_timedef} \ > > > ${_vt} \ > > > ${_zoneinfo} > > > diff --git a/share/terminfo/Makefile b/share/terminfo/Makefile > > > new file mode 100644 > > > index 000000000000..7bb11f3fdf24 > > > --- /dev/null > > > +++ b/share/terminfo/Makefile > > > @@ -0,0 +1,34 @@ > > > +PACKAGE=3D runtime > > > + > > > +.PATH: ${SRCTOP}/contrib/ncurses/misc > > > +TINFOBUILDDIR=3D ${.OBJDIR}/builddir > > > +CLEANDIRS+=3D builddir > > > + > > > +.include > > > + > > > +.if !defined(_SKIP_BUILD) > > > +all: terminfo > > > +.endif > > > +META_TARGETS+=3D terminfo install-terminfo > > > + > > > +terminfo: terminfo.src > > > + mkdir -p ${TINFOBUILDDIR} > > > + ${TIC_CMD} -x -o ${TINFOBUILDDIR} ${.ALLSRC} > > > + > > > +.if make(*install*) > > > +TINFOS!=3D cd ${TINFOBUILDDIR} && find * -type f | LC_ALL=3DC sort > > > +TINFOSDIRS=3D ${TINFOS:C/(.).*/\1/g:O:u} > > > +.endif > > > + > > > +beforeinstall: install-terminfo > > > +install-terminfo: > > > + mkdir -p ${DESTDIR}/usr/share/terminfo > > > + cd ${DESTDIR}/usr/share/terminfo; mkdir -p ${TINFOSDIRS} > > > +.for f in ${TINFOS} > > > + ${INSTALL} ${TAG_ARGS} \ > > > + -o ${BINOWN} -g ${BINGRP} -m ${NOBINMODE} \ > > > + ${TINFOBUILDDIR}/${f} ${DESTDIR}/usr/share/terminfo/${f} > > > +.endfor > > > + > > > +.include > > > + > > > > >=20 > > I think this had some unintended consequences, a POLA violation that sh= ould=20 > > be documented. Our termcap didn't support alternate screen buffers whil= e=20 > > terminfo does. Termcap did through t_te and t_ti but we didn't use them= =2E=20 > > Terminfo as delivered from the ncurses factory does supply rmcup and sm= cup;=20 > > our fullscreen apps such as nvi and top see them and use the alternate= =20 > > screen buffer. > >=20 > > The use of the alternate screen buffer is one of the things I hate abou= t=20 > > Linux. After running vi or top I expect the output to remain on the scr= een=20 > > so I can use some bit of information in my next command. We now have th= is=20 > > behaviour too. >=20 > Oh, I so hate that mis-feature of Linux, please please tell me there is > a simple knob to turn this off? I believe LESS also does this kind > of stuff, or atleast "man" on linux does, and that pees me off to no > end when I quit the man page and what I wanted is no longer on the screen. >=20 >=20 No this is not and I clear have 0 intention to have a complex patch on top = of the linux terminfo which would prefer easy sync in the futur. We can document how to use a definition which does not have the feature you= do not like. Best, Bapt --v42fwzf6tezfxlhv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAmA5MZsACgkQY4mL3PG3 Plrr+w//US1Iz8ryM3dOvMqDjb4xXrdPKq/UvzherByX6OvMzZam6/4/cqv8jCdo XACalXcJ+Bfbp88TiQu7pYUt0fVCSN1yBPQfj1XU1bKnvxWhX175TVAMfGvZSfvD k5Z6a59j9nW3GTGU1qTKoIBL5gm0uGkX8d8ZzueJdJUXC0fWnNb/In9FXvA/Kr2a FvMOOfLqP2ipYklzGg9imaet11WlhAugA7bYJ7uaT5NJO4N6ja9g8ZQm7kB5UhQD UTQBbdydb5hY/rhiPwTQdgpCdSJNdrYYHceZ44RoDu1QMhyTczKt6i1zd87kO73i pluKtu1t0fuSGoP7CknT0E8TGHRNCEO6juuAIn9Xq62rq/bn+eQCyWGkd8r9iIBq F01aKQc/80h7lFWwCM1AAR1ywp5c7oiyGKaKH6q9xGs/Kvrguxzioux8jrJuQWJb qcS74Axxt4QHxfK5iduD2nZXG0Hpoz6BhX7xzTiUJXnzjO7CeKZZ0gtuFw8jY23x jXaF7EPZJe5YXwnSWdL8KsC78U/bguSOhXvHTMBOmFuOQVGOxsbL9TAeicHC35x9 AtOT53xx/1rBxfhG1bR8v6zMiEdQWH/eIsTL/5MfP/Yy3otzHvFsy5g8pbE84Jhg 99uF451n+f5/ERFR/h916xOlMsM6j5m2yOk/JtrNdMxcXCb+3lE= =HChF -----END PGP SIGNATURE----- --v42fwzf6tezfxlhv--