Date: Tue, 8 Dec 2015 07:46:38 -0700 From: Adam Weinberger <adamw@adamw.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: =?utf-8?Q?Ren=C3=A9_Ladan?= <rene@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r403235 - head/emulators/fuse-roms Message-ID: <535A55E7-560F-4F2C-B9D4-AB83FFAB3C12@adamw.org> In-Reply-To: <290DB4608132EE92B98C7908@ogg.in.absolight.net> References: <201512072100.tB7L0Gnj081781@repo.freebsd.org> <0644124C99ECCEA1DF8E9EC0@atuin.in.mat.cc> <CADL2u4itn-bkKZkKj7rq9RGtkKpqQFJsh9pLUTiFKQ8bdg8Ssw@mail.gmail.com> <98D8063B4D072B57DAA53BE8@ogg.in.absolight.net> <CADL2u4jdeGOR-MMgbbuaGYbHMXuPT_Jn43jXpBxb_9Hu=-70Ag@mail.gmail.com> <290DB4608132EE92B98C7908@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 8 Dec, 2015, at 4:45, Mathieu Arnold <mat@FreeBSD.org> wrote:
>=20
>=20
>=20
> +--On 8 d=C3=A9cembre 2015 11:46:01 +0100 Ren=C3=A9 Ladan =
<rene@freebsd.org> wrote:
> | 2015-12-08 11:29 GMT+01:00 Mathieu Arnold <mat@freebsd.org>:
> |> +--On 8 d=C3=A9cembre 2015 10:08:19 +0100 Ren=C3=A9 Ladan =
<rene@freebsd.org>
> |> wrote:
> |> | 2015-12-08 10:04 GMT+01:00 Mathieu Arnold <mat@freebsd.org>:
> |> |> +--On 7 d=C3=A9cembre 2015 21:00:16 +0000 Rene Ladan =
<rene@FreeBSD.org>
> |> |> wrote:
> |> |> | +DOCS_PLIST_FILES=3D%%DOCSDIR%%/rom-distribution.txt
> |> |>=20
> |> |> When possible, don't use %%FOO%% thingies in PLIST_FILES, you =
can use
> |> |> ${DOCSDIR} directly.
> |> |>=20
> |> | I think I tried that before. It would almost work but "poudriere
> |> | testport" would fail.
> |>=20
> |> Then there was a bug in poudriere testport at that time. It now =
works.
> |>=20
> | That was in the previous version (3.10.9 ?). 'make check-plist' =
worked
> | fine. I'll change the line next time (but why is it bad?)
>=20
> The only reason there are %%foo%% thingies is because pkg-plist is a =
static
> file, and we need some way to do the variable expansion in them. The
> PLIST_FILES is in the Makefile, you can put the correct variables =
directly.
Wouldn't using ${DOCSDIR_REL} be closer to what %%DOCSDIR%% expands to?
# Adam
--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?535A55E7-560F-4F2C-B9D4-AB83FFAB3C12>