From owner-freebsd-bugs@FreeBSD.ORG  Sun Apr  3 15:50:09 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6A00C16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  3 Apr 2005 15:50:09 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4D92B43D1D
	for <freebsd-bugs@hub.freebsd.org>;
	Sun,  3 Apr 2005 15:50:09 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j33Fo9sR026092
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 3 Apr 2005 15:50:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j33Fo8Rl026091;
	Sun, 3 Apr 2005 15:50:09 GMT
	(envelope-from gnats)
Date: Sun, 3 Apr 2005 15:50:09 GMT
Message-Id: <200504031550.j33Fo8Rl026091@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Mike Tancsa <mike@sentex.net>
Subject: Re: kern/79420: panic using uplcom or uftdi serial adaptor and
 modem (USB)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Mike Tancsa <mike@sentex.net>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Apr 2005 15:50:09 -0000

The following reply was made to PR kern/79420; it has been noted by GNATS.

From: Mike Tancsa <mike@sentex.net>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: kern/79420: panic using uplcom or uftdi serial adaptor and
  modem (USB)
Date: Sun, 03 Apr 2005 11:45:04 -0400

 Ian Dowse provided the patch below which seems to stop the panics.  At 
 least 24hrs of testing has not resulted in a panic yet.
 
 --------------------------------------------
 
 In this case I wonder if the transfer needs to be aborted at all,
 since it is just restarted immediately afterwards. Mike, maybe you
 could try the following patch? Sorry, I haven't tested this, so I
 may be missing something obvious.
 
 Ian
 
 Index: dev/usb/ucom.c
 ===================================================================
 RCS file: /dump/FreeBSD-CVS/src/sys/dev/usb/ucom.c,v
 retrieving revision 1.51.2.2
 diff -u -r1.51.2.2 ucom.c
 --- dev/usb/ucom.c	30 Jan 2005 01:00:10 -0000	1.51.2.2
 +++ dev/usb/ucom.c	2 Apr 2005 13:10:27 -0000
 @@ -929,11 +929,13 @@
 
   	DPRINTF(("ucomstop: %d\n", flag));
 
 +#if 0
   	if (flag & FREAD) {
   		DPRINTF(("ucomstop: read\n"));
   		ucomstopread(sc);
   		ucomstartread(sc);
   	}
 +#endif
 
   	if (flag & FWRITE) {
   		DPRINTF(("ucomstop: write\n"));