Date: Wed, 25 Nov 2009 19:30:03 GMT From: Marius Strobl <marius@alchemy.franken.de> To: freebsd-fs@FreeBSD.org Subject: Re: sparc64/140797: Panic on 8.0-RC3/sparc64 as an NFS server Message-ID: <200911251930.nAPJU3sc009905@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR sparc64/140797; it has been noted by GNATS.
From: Marius Strobl <marius@alchemy.franken.de>
To: marcel@FreeBSD.org
Cc: bug-followup@FreeBSD.org, Greg Lewis <glewis@FreeBSD.org>,
Greg Lewis <glewis@eyesbeyond.com>
Subject: Re: sparc64/140797: Panic on 8.0-RC3/sparc64 as an NFS server
Date: Wed, 25 Nov 2009 20:28:14 +0100
On Tue, Nov 24, 2009 at 09:53:56PM -0800, Greg Lewis wrote:
> G'day Marius,
>
> On Mon, Nov 23, 2009 at 08:49:13PM +0100, Marius Strobl wrote:
> > Could you please test whether r199274/r199284 fix this problem?
> >
> > http://svn.freebsd.org/viewvc/base/head/sys/nfsserver/nfs_fha.c?r1=195202&r2=199284&diff_format=u
> >
> > --- head/sys/nfsserver/nfs_fha.c 2009/06/30 19:03:27 195202
> > +++ head/sys/nfsserver/nfs_fha.c 2009/11/15 03:09:50 199284
> > @@ -206,7 +206,7 @@
> > if (error)
> > goto out;
> >
> > - i->fh = *(const u_int64_t *)(fh.fh_generic.fh_fid.fid_data);
> > + bcopy(fh.fh_generic.fh_fid.fid_data, &i->fh, sizeof(i->fh));
> >
> > /* Content ourselves with zero offset for all but reads. */
> > if (procnum != NFSPROC_READ)
>
> Yes, this fixes it! Thanks. Sorry for not finding that myself.
>
> I realise it may be too late to get this into the release. It might be
> worth an ERRATA notice if so.
>
Marcel, do you have any such plans?
Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911251930.nAPJU3sc009905>