From owner-svn-src-head@freebsd.org Sat Oct 24 16:44:24 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B6EC244E87F; Sat, 24 Oct 2020 16:44:24 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CJRlC5yxvz3Y6G; Sat, 24 Oct 2020 16:44:23 +0000 (UTC) (envelope-from arichardson.kde@gmail.com) Received: by mail-ed1-f53.google.com with SMTP id l24so4734261edj.8; Sat, 24 Oct 2020 09:44:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rfy5XXmOD/9UEQzxrx9Q9XvvPvcqMFhpZb8CEkDyz6Y=; b=FzvmFfdYKNePYr0cLVOCHxEPkIkJlbHGJztLb6emvVczr8/j+rUV7JXVHkHv4bxtUA AqJ4kn6ua3EgO4jqvk9L9eufTdr8F9Sf0eQw7rCCvGav1jeLl9QewROCEP23TYoGxfgM SY2ntQfdSimJnkI3+8+QBnzrMoN+4NMyjZWY9v+PoiaW4qYwKIL07kiM2up6FwBnKn8E s/RJf/tTb3x6DyRZPLTiu/LWqrPSEMOEKSjO82j4YRmcPKeKTscRITnJu7SzLcKo/kcj B/2KHY4xuRmo1yWhZ9HsiCccGXln2ysuNQO3VFahdivedAWO0TNXR7nGqJvpw24h39y1 6ftg== X-Gm-Message-State: AOAM5300lfvikLDbFc7N8ZKh8+9bGBzI2SY4cYmMCUDw5oFaVmcqCGLT 9MNVGrXXNfeJdP1cH7hiloQ92NSngFeT4n0D X-Google-Smtp-Source: ABdhPJyBFPTeMVhuAmP/ZQo8eRda8Sm6KGNhNXABycceazcpKugx53VhgoN+kAR0ty4NbtPJ90ebGg== X-Received: by 2002:aa7:d495:: with SMTP id b21mr7603698edr.231.1603557861933; Sat, 24 Oct 2020 09:44:21 -0700 (PDT) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com. [209.85.128.49]) by smtp.gmail.com with ESMTPSA id j1sm1052097eje.118.2020.10.24.09.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Oct 2020 09:44:21 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id c194so5683283wme.2; Sat, 24 Oct 2020 09:44:21 -0700 (PDT) X-Received: by 2002:a1c:c28a:: with SMTP id s132mr3019729wmf.13.1603557861172; Sat, 24 Oct 2020 09:44:21 -0700 (PDT) MIME-Version: 1.0 References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> <317231603546378@mail.yandex.ru> In-Reply-To: From: Alexander Richardson Date: Sat, 24 Oct 2020 17:44:10 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r366993 - head/sys/net To: Warner Losh Cc: "Alexander V. Chernikov" , Hans Petter Selasky , Alexey Dokuchaev , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 4CJRlC5yxvz3Y6G X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of arichardsonkde@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=arichardsonkde@gmail.com X-Spamd-Result: default: False [-2.46 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; ARC_NA(0.00)[]; NEURAL_HAM_LONG(-0.96)[-0.964]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.43)[-0.432]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.53:from]; NEURAL_HAM_MEDIUM(-1.06)[-1.060]; FORGED_SENDER(0.30)[arichardson@freebsd.org,arichardsonkde@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.53:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[arichardson@freebsd.org,arichardsonkde@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2020 16:44:24 -0000 On Sat, 24 Oct 2020, 16:27 Warner Losh, wrote: > > > On Sat, Oct 24, 2020, 7:38 AM Alexander V. Chernikov > wrote: > >> 24.10.2020, 14:08, "Hans Petter Selasky" : >> > On 2020-10-24 14:52, Alexey Dokuchaev wrote: >> >> On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote: >> >>> New Revision: 366993 >> >>> URL: https://svnweb.freebsd.org/changeset/base/366993 >> >>> >> >>> Log: >> >>> Run code through "clang-format -style=file" with some additional >> fixes. >> >>> No functional change. >> >>> >> >>> ... >> >>> @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr, >> >>> >> >>> #ifdef INET6 >> >>> static inline void >> >>> -infiniband_ipv6_multicast_map(const struct in6_addr *addr, >> >>> - const uint8_t *broadcast, uint8_t *buf) >> >>> +infiniband_ipv6_multicast_map( >> >>> + const struct in6_addr *addr, const uint8_t *broadcast, uint8_t >> *buf) >> >>> { >> >> >> >> This is not how we format these in FreeBSD, please revert. It was >> correct >> >> before and no "fix" is need here. >> Given we already have nice .clang-format, that does most of the job, >> maybe it's worth considering looking into tweaking it further to fix this >> part? >> It would be nice if we could finally offload all formatting issues to the >> tool and focus on the actual code :-) >> > > It would be nice if it produced one of the style(9) acceptable formats > without disrupting things already acceptable. That's been the big problem > with the tweaks to date... some things are fixed, others break. It's > getting a lot closer, though > I've upstreamed a few fixes, but haven't got to the line wrapping/continuation indentation stuff yet. That part of clang format is not particularly easy to modify without breaking other stuff and I'm also rather short on time right now, so probably won't get to it any time soon. Alex