From owner-svn-src-all@freebsd.org Thu Dec 17 03:44:05 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1C18F4A8C4E for ; Thu, 17 Dec 2020 03:44:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CxHsx09sDz4njx for ; Thu, 17 Dec 2020 03:44:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id E7F34F19C for ; Thu, 17 Dec 2020 03:44:04 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f180.google.com with SMTP id g24so6850465qtq.12 for ; Wed, 16 Dec 2020 19:44:04 -0800 (PST) X-Gm-Message-State: AOAM532MY3kMcUoWmgkoFtdQ4iVqfhSMWDISeqOa3dZTtnVhLsYAR2na +y6wPrWHU6zqoB9TIEqtsMMGEbRe2ZsEROUkGGY= X-Received: by 2002:ac8:4e87:: with SMTP id 7mt49367339qtp.310.1608176644443; Wed, 16 Dec 2020 19:44:04 -0800 (PST) MIME-Version: 1.0 References: <202012170342.0BH3gs5B070847@repo.freebsd.org> In-Reply-To: <202012170342.0BH3gs5B070847@repo.freebsd.org> From: Kyle Evans Date: Wed, 16 Dec 2020 21:43:53 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r368713 - head/usr.sbin/freebsd-update Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 03:44:05 -0000 On Wed, Dec 16, 2020 at 9:43 PM Kyle Evans wrote: > > Author: kevans > Date: Thu Dec 17 03:42:54 2020 > New Revision: 368713 > URL: https://svnweb.freebsd.org/changeset/base/368713 > > Log: > freebsd-update: unconditionally regenerate passwd/login.conf files > > The existing logic is nice in theory, but in practice freebsd-update will > not preserve the timestamps on these files. When doing a major upgrade, e.g. > from 12.1-RELEASE -> 12.2-RELEASE, pwd.mkdb et al. appear in the INDEX and > we clobber the timestamp several times in the process of packaging up the > existing system into /var/db/freebsd-update/files and extracting for > comparisons. This leads to these files not getting regenerated when they're > most likely to be needed. > > Measures could be taken to preserve timestamps, but it's unclear whether > the complexity and overhead of doing so is really outweighed by the marginal > benefit. > > I observed this issue when pkg subsequently failed to install a package that > wanted to add a user, claiming that the user was removed in the process. > bapt@ pointed to this pre-existing bug with freebsd-update as the cause. > > PR: 234014, 232921 > Reviewed by: bapt, emaste > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D27635 > Bah, I found this one immediately after: PR: 235766