Date: Wed, 14 Jan 2015 23:39:32 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 196739] sysutils/munin-node: Several plugins broken out of the box Message-ID: <bug-196739-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D196739 Bug ID: 196739 Summary: sysutils/munin-node: Several plugins broken out of the box Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: mat@FreeBSD.org Reporter: darius@dons.net.au Flags: maintainer-feedback?(mat@FreeBSD.org) Assignee: mat@FreeBSD.org smart_ now wants smartpath to find smartctl (an alternative would be to mod= ify the plugin to look in the right place by default). Also, the sample config = runs it in group operator but this is not sufficient without modifying the permissions for all disk devices and xpt0. I changed it to run it as root. ipmi_sensor_ does not use an explicit path for ipmitool which causes proble= ms because (apparently) /usr/local/bin isn=E2=80=99t in the default munin path= . Modifying the plugin to use /usr/local/bin/ipmitool makes it work. It also seems to invert the limits for fans which cause problems so I reverted that change. --- /usr/local/share/munin/plugins/ipmi_sensor_.orig 2015-01-06 12:12:14.723448042 +1030 +++ /usr/local/share/munin/plugins/ipmi_sensor_ 2015-01-06 13:16:58.003180510 +1030 @@ -124,7 +124,7 @@ def get_sensor_names(): try: - p =3D Popen(["ipmitool","-I","open","sensor"], shell=3DFalse, stdo= ut=3DPIPE) + p =3D Popen(["/usr/local/bin/ipmitool","-I","open","sensor"], shell=3DFalse, stdout=3DPIPE) except OSError: return data =3D p.stdout.readlines() @@ -152,12 +152,12 @@ if curtime-mtime>CACHEAGE: if not SENSORS: try: - p =3D Popen(["ipmitool","-I","open","sensor"], shell=3DFal= se, stdout=3DPIPE) + p =3D Popen(["/usr/local/bin/ipmitool","-I","open","sensor= "], shell=3DFalse, stdout=3DPIPE) except OSError: return else: try: - p =3D Popen(["ipmitool","-I","open","sensor", "get", "--"]= + SENSORS, shell=3DFalse, stdout=3DPIPE) + p =3D Popen(["/usr/local/bin/ipmitool","-I","open","sensor= ", "get"] + SENSORS, shell=3DFalse, stdout=3DPIPE) except OSError: return data =3D p.stdout.read() @@ -254,12 +254,8 @@ warn_u =3D values['Upper Non-Critical'].replace("na","") #TODO add 'fans' - if 'rpm'=3D=3Dunit: - warn =3D "%s:%s" % (warn_u,warn_l) - crit =3D "%s:%s" % (crit_u,crit_l) - else: - warn =3D "%s:%s" % (warn_l,warn_u) - crit =3D "%s:%s" % (crit_l,crit_u) + warn =3D "%s:%s" % (warn_l,warn_u) + crit =3D "%s:%s" % (crit_l,crit_u) if warn!=3D":": print "%s.warning %s" % (nname, warn) The sample config file nut has a trailing =E2=80=9C for env.upsconf which c= auses it to fail. Also, sendmail_mailtraffic doesn=E2=80=99t work unless you have 'group whee= l=E2=80=99 so it can read /var/log/sendmail.st --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer mat@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-196739-13>