From owner-svn-src-head@freebsd.org Thu Mar 8 12:42:44 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16EB5F2DB25; Thu, 8 Mar 2018 12:42:44 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id 8A8D278996; Thu, 8 Mar 2018 12:42:43 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id A9907426FA2; Thu, 8 Mar 2018 23:42:34 +1100 (AEDT) Date: Thu, 8 Mar 2018 23:42:33 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Eitan Adler cc: Bruce Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315480 - in head/sys: dev/syscons dev/vt kern teken In-Reply-To: Message-ID: <20180308225049.S1249@besplex.bde.org> References: <201703181113.v2IBDs2T090790@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=cIaQihWN c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=JqhwoUi6xzlgNkRkyysA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 12:42:44 -0000 On Wed, 7 Mar 2018, Eitan Adler wrote: > On 18 March 2017 at 04:13, Bruce Evans wrote: >> Author: bde >> Date: Sat Mar 18 11:13:54 2017 >> New Revision: 315480 >> URL: https://svnweb.freebsd.org/changeset/base/315480 >> >> Log: >> Fix bright colors for syscons, and make them work for the first time >> for vt. Restore syscons' rendering of background (bg) brightness as >> foreground (fg) blinking and vice versa, and add rendering of blinking >> as background brightness to vt. > > Is this one safe to MFC ? Fairly safe, except it might depend on my previous changes in syscons. They were fairly carefully ordered. You probably want all of them except colorized kernel console output with default colors that not everyone would like. Syscons an be fixed much more easily by not using scteken (teken upper layers and scteken.c). scterm-sc.c from FreeBSD-7 requires only 46 lines of patches to work again. Known lost functionality in scteken will take an estimated 2000 lines of patches to fix. I have written about 1/3 of these. Bruce