From owner-svn-src-all@freebsd.org Tue Nov 27 19:00:13 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 921A311582E1; Tue, 27 Nov 2018 19:00:13 +0000 (UTC) (envelope-from dab0816@gmail.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D86698D79F; Tue, 27 Nov 2018 19:00:12 +0000 (UTC) (envelope-from dab0816@gmail.com) Received: by mail-qk1-x729.google.com with SMTP id y78so4494404qka.12; Tue, 27 Nov 2018 11:00:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:cc:references:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3xfpRGeVij1DePzKHWbKrKnAsZHtY1sPFGNudFvSvaA=; b=KZd/e+TqwVduqHqXzoBuRoLrDjFQSZcQbqreTpfF1cG4DzYTMmUqrIn+ANAKguDvvr AiVHj2HeGXzjU7Ljiltd3afkJ0bp9fR7BMTMWqTjDpi35WIjNcN8rLxPWjQGy9kK5Ist RucP9JqOqGvW7SA3b1Q0y+w7Maam8ZiRAivzLCrqN6ih6TYj8oPHxdeSN5aokYBCcwXx 7EY1wIItShdNH9vp5b8jIvGQ+e+7EgC8PryBsks+jnwCnP+kUuys1mHStISTYKJAoRLI fiTsj1TqzLNJ3RU6BSAP97PfdR94lsLc4yHXfli5o7kY9vX3Hg1kKgwhHIiLN5h5+p1j FpuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:cc:references:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3xfpRGeVij1DePzKHWbKrKnAsZHtY1sPFGNudFvSvaA=; b=XJv+8q38uotIOqrDquSDu+0j7OL0sZkcMBhdLN6A2uX6gbzaS/Z+tYdSZkljnftUPX wdbdUOXplvztvPDP1wMq5RqMfZoLZTfX3gFtKodO5ZDKG5/uxG9GVHQ6j+1GCeHGbTaQ x8WHJEdqmXOS9F6iVXxzEyrABGEcYK5WCWMMRzvzFzTjH9QdwgaTG95dOW4I4V63TJVF YdWgoRz3jBdmiD92bvtq8r+tOoZbYga8mYCtswPwX43NEpHRaiIlWN7b93CO6glPiqqY cpYIcbg2o+sua0mSQ6MXEudiX2JPYcOEoA/zBtTolklNbkaAnqXbASQarjvd7spuCBcu VmDg== X-Gm-Message-State: AA+aEWZObguAES8N9MRiqwJUeb+L9Ge5Slxnpq1kCNlGDH3haugWmwWW KQi9gKXM1wGRmhimmFFlB06Yw/57 X-Google-Smtp-Source: AFSGD/WrUL5vPbbRUbopYFQtSpVXFkVPIPmGFVCoTs0HZ6r2ix28r1h9eMwifR57r5FH961mQ2LRXg== X-Received: by 2002:a37:bb82:: with SMTP id l124mr30434288qkf.188.1543345212183; Tue, 27 Nov 2018 11:00:12 -0800 (PST) Received: from dab-xps-13-9370.localdomain (c-76-104-203-143.hsd1.wa.comcast.net. [76.104.203.143]) by smtp.gmail.com with ESMTPSA id t40sm2794845qth.46.2018.11.27.11.00.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Nov 2018 11:00:11 -0800 (PST) Sender: David Bright From: "David A. Bright" X-Google-Original-From: "David A. Bright" Subject: Re: svn commit: r341068 - head/tests/sys/kqueue/libkqueue To: cem@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201811271512.wARFCYmP092105@repo.freebsd.org> Openpgp: preference=signencrypt Autocrypt: addr=dab@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFgqQsIBCADfDUZ79qW2MKVRQl9l9zMYzppdHn+eS7KGjUP9hjmYUuX3vM0Sc5DlJ9Py 59Byucg8zo6eow1iv6NdiEPuUEYB2ujDP/kbmC397zEt6p9ldlL4PXXSJumpdZCzwz4ACYB5 ke7OCljNqbigzoZgX5DXjyjx87NfG6eWkbnEweDPmae7DGj5bwQmJPoTqvJR7Ot/R/73ix8l hph1vdl83Iqu+IDVdlXTI2Afz4UaCRdfDiXgMQIo/HABXJ90+TXG/vH37Jb0kBflql9sEaUs CcTvMrye0Wjgv3VSPZm3ZEgmR7UKR71p2MJVlVVZUH3FHQ2jDqKpCMi7F3ERlvRDktm/ABEB AAHNHkRhdmlkIEJyaWdodCA8ZGFiQGZyZWVic2Qub3JnPsLAfQQTAQoAJwUCWCpCwgIbAwUJ BaOagAULCQgHAwUVCgkICwUWAwIBAAIeAQIXgAAKCRAzeMsxoQO+aqagCADDt4FbZBz3VFev TEtAjuyzCDPmPom1MBwsh6KB2J84wKOsXPmZ7vqaZ2G70fCPNowqmHq56cAbp0BD1Lf6gD+3 imeacKc/E6n+L49LOhOtQ8EUyHs/nAUmlE1PrOS1w5wmCgRjPXa5k+zxj/YMsAEFdMn6UzOl 5MIJN/zhBB5tU2bkP5hF4rVvpQ1zlnSldoBLfPlG/w1RzvOSJfunZUTSNVrKYlSjEQ7q56ud xKoLPEdr+X8kqwZilh5WBiTt7mMw7lrP6dMV/GGmDg893J6conQ1l2RN6Un1gKlc3rgdz3sh ncr786WF3cV2dFSIrO/Pn3iNRR3uJouRLdLhU0kMzsBNBFgqQsIBCAC5ABwcVerpyp5NzHBD FSbxEyPab6HFH1E4zksEGyeypU8UW5acc2ko5Ovz7CE0n21uhBtIt/Lz5Koxz0LSqqnk9jIQ L/4XVvne+8YnT+Tf9DZv9We5K0tFit/DFgCzIpxacoxLGBRNSkSzFrAepvVinTk905igdYZY fxtHrAREU4BdqBMQtbgGaewHtOLlRRr+N4wkAZlJLa7RaLn5s/EakpmCM1eR8z0fOBNJSXlW Ozqh1cvwWZ00qj0rYXwXu0fgzpREmJFS01GByFuB4xDyqfAoynxKNBJH/qAcJTp7jST8PLWe 3Tblm4acsIAPHUcABgMnZYdMQnSwwa9/W1DlABEBAAHCwGUEGAEKAA8FAlgqQsICGwwFCQWj moAACgkQM3jLMaEDvmp8hQgAzKTYmU2cf35NdrtT9C7jBDWSVSDdyKHYSAKoP+vAkC3A1HH6 wohE5JvOZ6245vgBQwFHvzh2v7jDUWmB3CrcSSMUoUIwl15mWlCdCy/C3SAknxQx+zHYmx9v uHPS1yF2l0KPS30Kc1le1GqVYi5wxnWPo+gE3MH4DDh5LdDExYveMuBgybdNxV8Qvr25UghJ HrQCT+FCISo0FActO1Z5HzdOKxQe6KTn+zKr4yKCOe4kb7GUaAX3Pt82J7bMtwRzAKLyjMJV QueL/cr+geerKKrd8FyVAgQMhdBYD3lyjK6nGssgr4Og9+QtsE2RAVH9qqhcF3kI7nxJ7EDb /d3xag== Message-ID: <74f6433b-08ed-c6b3-fd23-8bb97719b56b@FreeBSD.org> Date: Tue, 27 Nov 2018 13:00:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D86698D79F X-Spamd-Result: default: False [-2.84 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[bright-family.net]; NEURAL_HAM_LONG(-1.00)[-0.995,0]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_TO(1.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[9.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.985,0]; IP_SCORE(-0.65)[ipnet: 2607:f8b0::/32(-1.78), asn: 15169(-1.38), country: US(-0.09)]; FORGED_SENDER(0.30)[david@bright-family.net,dab0816@gmail.com]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[david@bright-family.net,dab0816@gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 19:00:13 -0000 On 11/27/18 12:34 PM, Conrad Meyer wrote: > As long as we were correcting indentation whitespace, it seems like it > would have been good to go to tabs, per style(9), instead of spaces. > Or are these considered contrib code from NetBSD? A fair question. I'm not sure whether they should be considered contrib code or not. As the (vast?) majority the tab-using lines were from prior changes that I made, I thought I should return the files to their original spaces-instead-of-tabs, 4-space indent format on the theory that I should have recognized and matched the existing style in the first place. Not to mention that this change was much smaller and less disruptive; if I had converted the files to style(9), most lines in the files would have had to change. -- David Bright dab@FreeBSD.org