From owner-freebsd-hackers@FreeBSD.ORG Sun Feb 21 05:42:05 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 799161065672 for ; Sun, 21 Feb 2010 05:42:05 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from monday.kientzle.com (kientzle.com [66.166.149.50]) by mx1.freebsd.org (Postfix) with ESMTP id 3040A8FC08 for ; Sun, 21 Feb 2010 05:42:04 +0000 (UTC) Received: (from root@localhost) by monday.kientzle.com (8.14.3/8.14.3) id o1L5gC5e011154; Sun, 21 Feb 2010 05:42:12 GMT (envelope-from kientzle@freebsd.org) Received: from dark.x.kientzle.com (fw2.kientzle.com [10.123.1.2]) by kientzle.com with SMTP id wm7hcc558u3iyztw7rsbg8prsa; Sun, 21 Feb 2010 05:42:11 +0000 (UTC) (envelope-from kientzle@freebsd.org) Message-ID: <4B80C7E7.1090303@freebsd.org> Date: Sat, 20 Feb 2010 21:43:03 -0800 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.21) Gecko/20090601 SeaMonkey/1.1.16 MIME-Version: 1.0 To: bf1783@gmail.com References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@freebsd.org, Alex RAY Subject: Re: GEOM_ULZMA X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Feb 2010 05:42:05 -0000 b. f. wrote: >>> The code organization depends on what you want to do with it and how you >>> want to update the code in the future, if your lzma library is third party. >> LZMA made by Igor Pavlov, and since 4.62 it licensed under Public Domain. >> So we can use it, if we need. >> >>> If you never intend to update the lzma code then I guess it's fine to >>> embed it in a big .c file. For a port, it doesn't matter much since it >>> is your own thing. There are stricter rules on maintainability and style >>> if you want it in the base system. >> So, I think right place for lzma library under sys/contrib directory, if I "promise" >maintain it? > > There are already long-standing plans to import lzma compression > libraries into the base system, by the libarchive maintainers. Libarchive has hooks to support the liblzma library from Lasse Collin's "xz utils" package. When linked against this library, libarchive (and hence bsdtar) has full support for "bare" lzma streams and for Collin's "xz" format (which is a big improvement over bare lzma streams). Like Igor Pavlov's original code, the "xz utils" code is in the public domain. Officially, xz utils is in version 4.999.8beta; Collin has promised to bump the version to 5.0 once he feels the code is sufficiently stable. As far as I can tell, it's actually in pretty good shape now; the changes going in seem to mostly be minor portability fixes. I see no reason to not import the current version into the FreeBSD base system. I plan to do so but may not get to it very soon; I certainly would not complain if someone else beat me to it. ;-) There are other lzma libraries around, of course. In particular, I've seen references to the lzma libraries distributed with lzip. Unfortunately, lzip is GPLv3 so is not a candidate for inclusion in FreeBSD's base system. Tim