From owner-freebsd-scsi@freebsd.org  Sun Nov  6 20:57:08 2016
Return-Path: <owner-freebsd-scsi@freebsd.org>
Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 198DCC33E8B
 for <freebsd-scsi@mailman.ysv.freebsd.org>;
 Sun,  6 Nov 2016 20:57:08 +0000 (UTC)
 (envelope-from tuexen@freebsd.org)
Received: from drew.franken.de (mail-n.franken.de [193.175.24.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "*.franken.de",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D5027EE6;
 Sun,  6 Nov 2016 20:57:07 +0000 (UTC)
 (envelope-from tuexen@freebsd.org)
Received: from [192.168.1.101] (p508F13AC.dip0.t-ipconnect.de [80.143.19.172])
 (Authenticated sender: macmic)
 by mail-n.franken.de (Postfix) with ESMTPSA id 45885721E281A;
 Sun,  6 Nov 2016 21:57:04 +0100 (CET)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\))
Subject: Re: mpt driver issue?
From: Michael Tuexen <tuexen@freebsd.org>
In-Reply-To: <e9698b93-11e6-530a-1d27-ef45706eae66@freebsd.org>
Date: Sun, 6 Nov 2016 21:57:02 +0100
Cc: freebsd-scsi@freebsd.org,
 scottl@freebsd.org
Content-Transfer-Encoding: 7bit
Message-Id: <CA6234F2-C0BF-472E-B904-FFBAE0ED29F9@freebsd.org>
References: <CA9B9B19-5311-4A4E-87ED-8771C1000BEC@freebsd.org>
 <4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org>
 <e9698b93-11e6-530a-1d27-ef45706eae66@freebsd.org>
To: Sean Bruno <sbruno@freebsd.org>
X-Mailer: Apple Mail (2.3251)
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
 autolearn=disabled version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi/>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
 <mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Nov 2016 20:57:08 -0000

> On 6 Nov 2016, at 20:41, Sean Bruno <sbruno@freebsd.org> wrote:
> 
> 
> 
> On 11/06/16 10:54, Michael Tuexen wrote:
>> Dear all,
>> 
>> it was suggested on current@ to forward this to freebsd-scsi@
>> 
>> The problem shows up since r308268 and it looks like an issue
>> in the mpt driver...
>> 
>> Best regards
>> Michael
> 
> I don't see any *obvious* reason that we should hold the mpt lock here.
> It looks ok to just drop it.
I tried that and the system (with WITNESS) panic'ed...
Can't write a core (not a surprise).

Best regards
Michael
> 
> sean
> 
> Index: sys/dev/mpt/mpt.c
> ===================================================================
> --- sys/dev/mpt/mpt.c   (revision 308345)
> +++ sys/dev/mpt/mpt.c   (working copy)
> @@ -2284,9 +2284,7 @@
>        mpt_lprt(mpt, MPT_PRT_DEBUG, "doorbell req = %s\n",
>            mpt_ioc_diag(mpt_read(mpt, MPT_OFFSET_DOORBELL)));
> 
> -       MPT_LOCK(mpt);
>        error = mpt_configure_ioc(mpt, 0, 0);
> -       MPT_UNLOCK(mpt);
> 
>        return (error);
> }
> 
> 
> 
> 
>