From owner-svn-src-all@freebsd.org Thu Dec 10 18:07:26 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 67C2B4B2410; Thu, 10 Dec 2020 18:07:26 +0000 (UTC) (envelope-from rew@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CsMML2Xzdz4mSg; Thu, 10 Dec 2020 18:07:26 +0000 (UTC) (envelope-from rew@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4A2E11D110; Thu, 10 Dec 2020 18:07:26 +0000 (UTC) (envelope-from rew@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 0BAI7QuQ009837; Thu, 10 Dec 2020 18:07:26 GMT (envelope-from rew@FreeBSD.org) Received: (from rew@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 0BAI7PFi009833; Thu, 10 Dec 2020 18:07:25 GMT (envelope-from rew@FreeBSD.org) Message-Id: <202012101807.0BAI7PFi009833@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: rew set sender to rew@FreeBSD.org using -f From: Robert Wing Date: Thu, 10 Dec 2020 18:07:25 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r368519 - in head: sys/dev/bvm usr.sbin/bhyve X-SVN-Group: head X-SVN-Commit-Author: rew X-SVN-Commit-Paths: in head: sys/dev/bvm usr.sbin/bhyve X-SVN-Commit-Revision: 368519 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2020 18:07:26 -0000 Author: rew Date: Thu Dec 10 18:07:25 2020 New Revision: 368519 URL: https://svnweb.freebsd.org/changeset/base/368519 Log: Add deprecation notice for bvmconsole and bvmdebug Now that bhyve(8) supports UART, bvmconsole and bvmdebug are no longer needed. Mark the '-b' and '-g' flag as deprecated for bhyve(8). These will be removed in 13. Reviewed by: jhb, grehan Approved by: kevans (mentor) MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D27519 Modified: head/sys/dev/bvm/bvm_console.c head/sys/dev/bvm/bvm_dbg.c head/usr.sbin/bhyve/bhyve.8 head/usr.sbin/bhyve/bhyverun.c Modified: head/sys/dev/bvm/bvm_console.c ============================================================================== --- head/sys/dev/bvm/bvm_console.c Thu Dec 10 17:48:34 2020 (r368518) +++ head/sys/dev/bvm/bvm_console.c Thu Dec 10 18:07:25 2020 (r368519) @@ -107,6 +107,8 @@ static void cn_drvinit(void *unused) { struct tty *tp; + + gone_in(13, "bvmconsole"); if (bvm_consdev.cn_pri != CN_DEAD) { tp = tty_alloc(&bvm_ttydevsw, NULL); Modified: head/sys/dev/bvm/bvm_dbg.c ============================================================================== --- head/sys/dev/bvm/bvm_dbg.c Thu Dec 10 17:48:34 2020 (r368518) +++ head/sys/dev/bvm/bvm_dbg.c Thu Dec 10 18:07:25 2020 (r368519) @@ -61,6 +61,8 @@ bvm_dbg_probe(void) disabled = 0; resource_int_value("bvmdbg", 0, "disabled", &disabled); + gone_in(13, "bvmdebug"); + if (!disabled) { if (resource_int_value("bvmdbg", 0, "port", &port) == 0) bvm_dbg_port = port; Modified: head/usr.sbin/bhyve/bhyve.8 ============================================================================== --- head/usr.sbin/bhyve/bhyve.8 Thu Dec 10 17:48:34 2020 (r368518) +++ head/usr.sbin/bhyve/bhyve.8 Thu Dec 10 18:07:25 2020 (r368519) @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd Jun 25, 2020 +.Dd December 8, 2020 .Dt BHYVE 8 .Os .Sh NAME @@ -104,7 +104,8 @@ Enable a low-level console device supported by .Fx kernels compiled with .Cd "device bvmconsole" . -This option will be deprecated in a future version. +This option is deprecated and will be removed in +.Fx 13.0 . .It Fl c Op Ar setting ... Number of guest virtual CPUs and/or the CPU topology. @@ -145,7 +146,8 @@ kernels compiled with .Cd "device bvmdebug" , allow a remote kernel kgdb to be relayed to the guest kernel gdb stub via a local IPv4 address and this port. -This option will be deprecated in a future version. +This option is deprecated and will be removed in +.Fx 13.0 . .It Fl G Ar port Start a debug server that uses the GDB protocol to export guest state to a debugger. Modified: head/usr.sbin/bhyve/bhyverun.c ============================================================================== --- head/usr.sbin/bhyve/bhyverun.c Thu Dec 10 17:48:34 2020 (r368518) +++ head/usr.sbin/bhyve/bhyverun.c Thu Dec 10 18:07:25 2020 (r368519) @@ -1124,6 +1124,7 @@ main(int argc, char *argv[]) acpi = 1; break; case 'b': + warnx("-b flag is deprecated and will be removed in FreeBSD 13.0"); bvmcons = 1; break; case 'D': @@ -1145,6 +1146,7 @@ main(int argc, char *argv[]) memflags |= VM_MEM_F_INCORE; break; case 'g': + warnx("-g flag is deprecated and will be removed in FreeBSD 13.0"); dbg_port = atoi(optarg); break; case 'G':