From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jul 20 08:50:22 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E96116A4CF for ; Tue, 20 Jul 2004 08:50:22 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E400D43D5A for ; Tue, 20 Jul 2004 08:50:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i6K8oLMY013771 for ; Tue, 20 Jul 2004 08:50:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6K8oLN7013770; Tue, 20 Jul 2004 08:50:21 GMT (envelope-from gnats) Resent-Date: Tue, 20 Jul 2004 08:50:21 GMT Resent-Message-Id: <200407200850.i6K8oLN7013770@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C91616A4CE for ; Tue, 20 Jul 2004 08:45:27 +0000 (GMT) Received: from mail.parodius.com (mail.parodius.com [64.62.145.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E84343D48 for ; Tue, 20 Jul 2004 08:45:27 +0000 (GMT) (envelope-from jdc@pentarou.parodius.com) Received: from pentarou.parodius.com (jdc@localhost [127.0.0.1]) by mail.parodius.com (8.12.11/8.12.11) with ESMTP id i6K8jQu6017353 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 20 Jul 2004 01:45:26 -0700 (PDT) (envelope-from jdc@pentarou.parodius.com) Received: (from jdc@localhost) by pentarou.parodius.com (8.12.11/8.12.11/Submit) id i6K8jQcT017352; Tue, 20 Jul 2004 01:45:26 -0700 (PDT) (envelope-from jdc) Message-Id: <200407200845.i6K8jQcT017352@pentarou.parodius.com> Date: Tue, 20 Jul 2004 01:45:26 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/69334: Fix for /suphp.log (should be /var/log/suphp.log) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jeremy Chadwick List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2004 08:50:22 -0000 >Number: 69334 >Category: ports >Synopsis: Fix for /suphp.log (should be /var/log/suphp.log) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Jul 20 08:50:21 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 4.10-PRERELEASE i386 >Organization: Parodius Networking >Environment: System: FreeBSD pentarou.parodius.com 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #0: Wed May 5 03:33:17 PDT 2004 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386 >Description: The present suphp port has some incorrect framework for specification of where the logfile points, assuming the user DOES NOT specify the LOG_PATH variable upon build (by default, it's empty). The logfile will end up in / (a.k.a. /suphp.log), which is naughty. The included Makefile patch should fix things up by removing LOG_PATH and WITH_LOGNAME, and using a single variable: LOGFILE, which by default points to /var/log/suphp.log. >How-To-Repeat: Build suphp without defining LOG_PATH. >Fix: See attached patch below. --- Makefile.orig Thu Jul 15 15:13:36 2004 +++ Makefile Tue Jul 20 01:36:37 2004 @@ -19,8 +19,7 @@ USE_APACHE= yes CONFLICTS= mod_php4-4* php-4.* -LOG_PATH?= ${WITH_LOGPATH} -WITH_LOGNAME?= suphp.log +LOGFILE?= /var/log/suphp.log PHP_PATH?= ${LOCALBASE}/bin/php APACHE_USER?= ${WWWOWN} MIN_UID?= 80 @@ -31,7 +30,7 @@ LANG= en de CONFIGURE_ARGS+= --with-php=${PHP_PATH} \ - --with-logfile=${LOG_PATH}/${WITH_LOGNAME} \ + --with-logfile=${LOGFILE} \ --with-apache-user=${APACHE_USER} \ --with-min-gid=${MIN_UID} \ --with-min-uid=${MIN_GID} \ @@ -52,9 +51,6 @@ .endif ## WITH_SETID_MODE: Mode to use for setting UID/GID. CONFIGURE_ARGS+= --with-setid-mode=${WITH_SETID_MODE} -## WITH_LOGPATH (formerly known as LOG_PATH): logging directory -## (default: /var/log) -## WITH_LOGNAME: log file name (default suphp.log) .include >Release-Note: >Audit-Trail: >Unformatted: