From owner-svn-src-all@freebsd.org Thu Jan 30 21:14:27 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AC20E1FF5C0 for ; Thu, 30 Jan 2020 21:14:27 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487tQV5RkTz3C4g for ; Thu, 30 Jan 2020 21:14:26 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: by mail-pl1-x62c.google.com with SMTP id b22so1809352pls.12 for ; Thu, 30 Jan 2020 13:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jroberson-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=mK7je99l1WH3SlaRe1g9ESQocfMDfltdN8N7FcCRf0M=; b=cSZFJWziJkVtzYYW0RidLFTuqAJUHgpnPeMcJN0JImwTbtqcZJOVLaIVKVe/WhUBvL mC6HfPusH5FGv+/yf3HgZyZ2uet6HYY1xu/ASTInKebPajAEP496otPuGd0k2i1dhK6d S2tB2n0gR08tuP+/9l7EiHx5EKSBwRWMC/D3PN1wttUftsDfujgkSIRzn1wgspyKNgjN nb7aTcfn+5KFXHBBMUd5b0xqU7t+noXql23IZW3f8qqiPvkJzHvyIltpzmSRXNydw2eD jYTvXJAfU7c/x5Hdsf0Et4zTcdWKp7XjOKhTETT6gzcrXlSk2PaiMym4BwD7dfx61khe 1onA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=mK7je99l1WH3SlaRe1g9ESQocfMDfltdN8N7FcCRf0M=; b=RmJV1DJsmdNemYm/wByRRg140Acx6+GtnsCcQiCC3dmuSyzWM/oajMYVqUW5ygfSg1 vB9Jnxxgma5H24tCIG81NdtRVdOmO7dB1hkCh6CXiTFsWDtoCfkiHgmideO7Dmsqrd+s n7zbW1aamxFnJkmS8RkpdS3OFGqL4s4t9/VVIhBpvBeFoCmUqVUSbMo4RQuxpkOFW8sP N2UeE/o6OYAexf7HiPglz3URV6RYQSFAdEGg+wcUDd/6oJOmEHbeeRWk37vUJZt8bRdP fElKP+NOV/+4RujTHfa18IWlbXrj/JqJ+EAFffLfIRja9r8bjFACEKWrRY0gKeJhheSL rvDQ== X-Gm-Message-State: APjAAAXGfNwc5IqFmdK7I4IQn1bjM96jarA15920q/tFsTmHPXS/b4MP 9a3gXoetpIZ98hM3Pztb2NLQmgs56q8= X-Google-Smtp-Source: APXvYqzBHkga2XR9IpLcx/WCMyok3csM4tMw4CeTGcRekRgCjUD3RQGLHnxN+zLX1OTS/jPuWalIRA== X-Received: by 2002:a17:90a:ff15:: with SMTP id ce21mr8106339pjb.124.1580418865382; Thu, 30 Jan 2020 13:14:25 -0800 (PST) Received: from rrcs-76-81-105-82.west.biz.rr.com (rrcs-76-81-105-82.west.biz.rr.com. [76.81.105.82]) by smtp.gmail.com with ESMTPSA id y3sm7738807pff.52.2020.01.30.13.14.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jan 2020 13:14:24 -0800 (PST) Date: Thu, 30 Jan 2020 11:14:22 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Hans Petter Selasky cc: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357293 - head/sys/net In-Reply-To: <1bd0ae2c-3b5a-dfd7-747b-75af6f8d4d03@selasky.org> Message-ID: References: <202001301204.00UC43Rw022059@repo.freebsd.org> <20200130205629.GK1268@FreeBSD.org> <1bd0ae2c-3b5a-dfd7-747b-75af6f8d4d03@selasky.org> User-Agent: Alpine 2.21.9999 (BSF 287 2018-06-16) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 487tQV5RkTz3C4g X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=jroberson-net.20150623.gappssmtp.com header.s=20150623 header.b=cSZFJWzi; dmarc=none; spf=none (mx1.freebsd.org: domain of jroberson@jroberson.net has no SPF policy when checking 2607:f8b0:4864:20::62c) smtp.mailfrom=jroberson@jroberson.net X-Spamd-Result: default: False [-4.28 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[jroberson-net.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[jroberson.net]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[jroberson-net.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[c.2.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-2.48)[ip: (-8.55), ipnet: 2607:f8b0::/32(-2.03), asn: 15169(-1.78), country: US(-0.05)] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 21:14:27 -0000 On Thu, 30 Jan 2020, Hans Petter Selasky wrote: > On 2020-01-30 21:56, Gleb Smirnoff wrote: >> On Thu, Jan 30, 2020 at 12:04:03PM +0000, Hans Petter Selasky wrote: >> H> Author: hselasky >> H> Date: Thu Jan 30 12:04:02 2020 >> H> New Revision: 357293 >> H> URL: https://svnweb.freebsd.org/changeset/base/357293 >> H> >> H> Log: >> H> Widen EPOCH(9) usage in netisr. >> H> >> H> Software interrupt handlers are allowed to sleep. In swi_net() there >> H> is a read lock behind NETISR_RLOCK() which in turn ends up calling >> H> msleep() which means the whole of swi_net() cannot be protected by an >> H> EPOCH(9) section. By default the NETISR_LOCKING feature is disabled. >> H> >> H> This issue was introduced by r357004. This is a preparation step for >> H> replacing the functionality provided by r357004. >> H> >> H> Found by: kib@ >> H> Sponsored by: Mellanox Technologies >> >> What?! NETISR_RLOCK() which in turn ends up calling msleep()? Can you >> please >> explain this nonsense? >> > > See rms_rlock_fallback() in kern_rmlock.c . The network stack uses rm_ not rms_. Jeff > > --HPS >