From nobody Mon Feb 6 22:05:21 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P9gLF3j74z3nTXq; Mon, 6 Feb 2023 22:05:25 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P9gLF2sjvz4Fbc; Mon, 6 Feb 2023 22:05:25 +0000 (UTC) (envelope-from se@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675721125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0i5FpuvEjonuhGNAn0OfXcGbnLRO06wpIiRhy2QaekM=; b=eitTivYCj4sH3Z8IRm8jmAEHPKEfF25E/9kFN0TY/W57eVv81fuU6IWfzGwM1jT0FSvNKe ZgSb87mJaoPrwgz2sGGf+sT3tcX50aPY80l00r2SjVpQ3PoZgBXzbQVmop//hI7gqUk2Ma LBbTboOJavlFO+unIufsD9dHpWaLy1ZRHotLWBHI2fjNh+MLYxy9sWW6E8p1TURzYstQzw HsxJ8vSxa7c+qDV288TCiN016qNRwHAcJVoGUcnC1Sew4g+SFtyOYB26ySoT/EtUpgCpOx nWT1/ccL17k/zRlT1Hb/IdXl/hSJ+HRVz+AS1WEJA27dKE5V5FVR1uWMDpSAzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675721125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0i5FpuvEjonuhGNAn0OfXcGbnLRO06wpIiRhy2QaekM=; b=hWxJUtuBV7SAtpG/090C0zdSrx/zEZFZ+H+V+AWSWTbbfLRAHLYSVOZXMRlTz0ol1pNETY FdZfFaMbpwkbDrsAJ/N/3TqR00N8wLyPLak4zZicbxAuJoT4mAPJ5f4gpr7awKKFl7/USx k3385xBIOj0SJcOb163WB3VVXR7iTx7moupFNYFzTBPZ4sItIiOzNKK/jIUCkYN+O8ylTw 0iBhtKtMFsTNg9cj653TNU9XmOEBC9o0qwDOcxznPjaoh6bUqP4VbZxTkI/QUgOmBNPV+M W/GE4BOgffCsmVX3UYOZ7G3BiuYEIuJG/nEqQIZIKXx5ifDcqO5X4+mOUdSBOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675721125; a=rsa-sha256; cv=none; b=us+xiPUk0taQ1xX/6tYjTZfPjjC3ms1ZdtBLDiRyU7OcaWGcytO5sW7vd5szILU5aAebIl rVV3njziiTT6QpQYR67v9NEGshCvn2nYMrC9lTvjzjDEWTxX5Hr4bA9gc9iJN5lAeYAxQH BTOhBvnaXfPvp631mAoOXnq/XXC5AmFOaqBBSEk2vrKB2/AruZfEJws2FO3k4O+WR6oJxz LTg8xP0ierIhoWTiTjM3Z1rZ/LAer4FOPYBPHDbBFjhU5WKGEjG3vItWAg8cIJ8h+IipHY DussD9kSmTLOdttY7xmMKnVDjIgcyoJvhhKulyk6Zqv8q/D/rK13D+RsT2I3BQ== Received: from [IPV6:2003:cd:5f2a:1000:9003:bde5:29b4:7117] (p200300cd5f2a10009003bde529b47117.dip0.t-ipconnect.de [IPv6:2003:cd:5f2a:1000:9003:bde5:29b4:7117]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P9gLD1TMqz1QLm; Mon, 6 Feb 2023 22:05:24 +0000 (UTC) (envelope-from se@freebsd.org) Message-ID: Date: Mon, 6 Feb 2023 23:05:21 +0100 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 From: =?UTF-8?Q?Stefan_E=c3=9fer?= Subject: Please approve the fix to the keymap code to let it go into 13.2 ... Content-Language: de-DE, en-US To: Warner Losh , Jessica Clarke , Emmanuel Vadot Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202302011630.311GUmt1068106@gitrepo.freebsd.org> <84830C1A-149F-4B05-99DC-1E0B50C8B59A@freebsd.org> <297c877d-2a2f-70cf-604c-e458634cb068@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N Am 04.02.23 um 16:19 schrieb Warner Losh: [...] > The ioctl handler in kbd/kbd.c has been extended in the same > way as had been used to support 32 bit key codes in the main > key map (with similar backwards compatibility code). > > Support of kbdcontrol built with the patched kbio.h on an old > kernel could be added to kbdcontrol.c - but we do not support > running a new user land on an old kernel, in general. (The > old kbdcontrol on a new kernel could load the normal keymap, > but the dead key map would be ignored.) > > > "In general" is true. However, this case is on the edge of being > one that we should do, based on how hard it is. You run into > needing this if you boot an old kernel because the new kernel > is broken on your hardware, but you've already done an install > world (this happens, even for people that follow the rules sometimes > for problems that aren't fatal to boot, but may be too crashy > to build a new kernel). Since this affects one's ability to interact > with the system with non-standard keyboards, how hard would > it be to retain the old code as a fallback if the new ioctl fails to > work? If it's quite hard, then we can skip it. If it isn't too hard, > please consider it...  Also, what's the behavior of the failure? I have created review D38388 (https://reviews.freebsd.org/D38388) to make kbdcontrol fall back to the old ioctl() invocation when executed on an old kernel. Without this patch, kbdcontrol can load the "normal" key codes when run on an old kernel, but the dead key table will not be loaded or displayed (i.e. accented characters defined in the dead key table will not be accessible on the console). I'd appreciate approval of the patches, and would apply D38381 first and D38388 on top to allow it to be reverted after a grace period (of a length to be determined). I have tested all combinations of the kernel and userland patches and verified correct results. But it may already be too late to get these patches into 13-STABLE before 13.2 is tagged. These patches fix an issue that affects some people (with accented characters above 255). The keymaps with dead key combinations that generate character codes above 255 are: centraleuropean.kbd centraleuropean.qwerty.kbd cz.kbd fr.bepo.kbd gr.101.acc.kbd gr.elot.acc.kbd gr.kbd sk.kbd Regards, STefan