From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 30 19:10:26 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 205801065688 for ; Tue, 30 Mar 2010 19:10:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 106D28FC08 for ; Tue, 30 Mar 2010 19:10:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2UJAPiw052334 for ; Tue, 30 Mar 2010 19:10:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2UJAPGM052325; Tue, 30 Mar 2010 19:10:25 GMT (envelope-from gnats) Date: Tue, 30 Mar 2010 19:10:25 GMT Message-Id: <201003301910.o2UJAPGM052325@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/144749: commit references a PR X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 19:10:26 -0000 The following reply was made to PR kern/144749; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/144749: commit references a PR Date: Tue, 30 Mar 2010 19:08:20 +0000 (UTC) Author: jhb Date: Tue Mar 30 19:07:41 2010 New Revision: 205900 URL: http://svn.freebsd.org/changeset/base/205900 Log: Use panic() (which the environment is required to provide to libstand) to implement assert() instead of relying on a non-required exit(). The exit() invocation also did not match the semantics of the exit() routine that current boot environments happen to require. PR: kern/144749 Discussed with: bde MFC after: 1 week Modified: head/lib/libstand/assert.c Modified: head/lib/libstand/assert.c ============================================================================== --- head/lib/libstand/assert.c Tue Mar 30 19:06:54 2010 (r205899) +++ head/lib/libstand/assert.c Tue Mar 30 19:07:41 2010 (r205900) @@ -35,10 +35,10 @@ void __assert(const char *func, const char *file, int line, const char *expression) { if (func == NULL) - printf("Assertion failed: (%s), file %s, line %d.\n", + panic("Assertion failed: (%s), file %s, line %d.\n", expression, file, line); else - printf("Assertion failed: (%s), function %s, file %s, line " - "%d.\n", expression, func, file, line); - exit(); + panic( + "Assertion failed: (%s), function %s, file %s, line %d.\n", + expression, func, file, line); } _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"