From owner-freebsd-sparc64@FreeBSD.ORG Tue Oct 18 09:00:24 2011 Return-Path: Delivered-To: freebsd-sparc64@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A759D1065674 for ; Tue, 18 Oct 2011 09:00:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 38E098FC12 for ; Tue, 18 Oct 2011 09:00:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p9I90Nrt064309 for ; Tue, 18 Oct 2011 09:00:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p9I90NZq064308; Tue, 18 Oct 2011 09:00:23 GMT (envelope-from gnats) Resent-Date: Tue, 18 Oct 2011 09:00:23 GMT Resent-Message-Id: <201110180900.p9I90NZq064308@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-sparc64@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Peter Jeremy Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34374106564A for ; Tue, 18 Oct 2011 08:53:32 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail28.syd.optusnet.com.au (mail28.syd.optusnet.com.au [211.29.133.169]) by mx1.freebsd.org (Postfix) with ESMTP id C3F018FC13 for ; Tue, 18 Oct 2011 08:53:31 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c220-239-116-103.belrs4.nsw.optusnet.com.au [220.239.116.103]) by mail28.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p9I8rShc011151 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 18 Oct 2011 19:53:29 +1100 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.5/8.14.4) with ESMTP id p9I8pR0h020982; Tue, 18 Oct 2011 19:51:27 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.5/8.14.4/Submit) id p9I8pRhR020981; Tue, 18 Oct 2011 19:51:27 +1100 (EST) (envelope-from peter) Message-Id: <201110180851.p9I8pRhR020981@server.vk2pj.dyndns.org> Date: Tue, 18 Oct 2011 19:51:27 +1100 (EST) From: Peter Jeremy To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: sparc64/161764: [patch] Support dumping to Solaris swap partitions X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Peter Jeremy List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2011 09:00:24 -0000 >Number: 161764 >Category: sparc64 >Synopsis: [patch] Support dumping to Solaris swap partitions >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-sparc64 >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Oct 18 09:00:22 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Peter Jeremy >Release: FreeBSD 10-CURRENT sparc64 >Organization: n/a >Environment: System: FreeBSD [10-current r226167 - full details not immediately available] >Description: FreeBSD currently only allows dumping onto either unused or FreeBSD swap partitions. Where systems are shared between FreeBSD and Solaris, it makes sense to allow both OSs to share common swap partitions. FreeBSD already allows swapping onto Solaris swap partitions - it just refuses to allow crashdumps. The attached patch fixes this. >How-To-Repeat: Attempt to dumpon(8) a Solaris swap partition. Kernel reports: GEOM_PART: Partition 'da0b' not suitable for kernel dumps (wrong type?) >Fix: Index: sys/geom/part/g_part_vtoc8.c =================================================================== RCS file: /usr/ncvs/src/sys/geom/part/g_part_vtoc8.c,v retrieving revision 1.12 diff -u -r1.12 g_part_vtoc8.c --- sys/geom/part/g_part_vtoc8.c 8 May 2011 12:28:13 -0000 1.12 +++ sys/geom/part/g_part_vtoc8.c 17 Oct 2011 01:27:27 -0000 @@ -274,7 +274,8 @@ */ table = (struct g_part_vtoc8_table *)basetable; tag = be16dec(&table->vtoc.part[entry->gpe_index - 1].tag); - return ((tag == 0 || tag == VTOC_TAG_FREEBSD_SWAP) ? 1 : 0); + return ((tag == 0 || tag == VTOC_TAG_SWAP || + tag == VTOC_TAG_FREEBSD_SWAP) ? 1 : 0); } static int >Release-Note: >Audit-Trail: >Unformatted: