From owner-freebsd-current@FreeBSD.ORG  Fri Jun 15 22:13:58 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 523EF16A400
	for <current@freebsd.org>; Fri, 15 Jun 2007 22:13:58 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 148B513C44C
	for <current@freebsd.org>; Fri, 15 Jun 2007 22:13:58 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 590F217380
	for <current@freebsd.org>; Fri, 15 Jun 2007 22:13:56 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id l5FMECPT001627
	for <current@freebsd.org>; Fri, 15 Jun 2007 22:14:12 GMT
	(envelope-from phk@critter.freebsd.dk)
To: current@freebsd.org
From: Poul-Henning Kamp <phk@phk.freebsd.dk>
Date: Fri, 15 Jun 2007 22:14:12 +0000
Message-ID: <1626.1181945652@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: 
Subject: [REVIEW]: add multicast NULL route
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2007 22:13:58 -0000


On a system without a default route, multicast simply doesn't work.

This patch adds a route into lo0 for the entire multicast space.

A similar route were created in /etc/netstart until version 1.32
where it was moved to sysconfig (1.14) where the incorrect resolution
to conf/1007 commented it out in (1.36) and subsequently it was
lost in the conversion to new rc world ordering.

As a stylistic feature of this patch, we no longer encroach on the
administrators namespace by prepending a couple of "__" on the
internal magic routes.

Review and comments please.

Index: routing
===================================================================
RCS file: /home/ncvs/src/etc/rc.d/routing,v
retrieving revision 1.143
diff -u -r1.143 routing
--- routing	2 May 2007 15:49:30 -0000	1.143
+++ routing	15 Jun 2007 22:03:59 -0000
@@ -31,12 +31,17 @@
 
 static_start()
 {
+	# The multicast range must be covered by a route, one way or another
+	# or multicast will simply not work.
+	static_routes="__mcast ${static_routes}"
+	route___mcast="-static -net 224.0.0.0/4 -interface lo0"
+
 	case ${defaultrouter} in
 	[Nn][Oo] | '')
 		;;
 	*)
-		static_routes="default ${static_routes}"
-		route_default="default ${defaultrouter}"
+		static_routes="__default ${static_routes}"
+		route___default="__default ${defaultrouter}"
 		;;
 	esac
 
-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.