From owner-svn-src-head@FreeBSD.ORG Fri Dec 20 18:01:18 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0A1354A1; Fri, 20 Dec 2013 18:01:18 +0000 (UTC) Received: from mail-we0-x231.google.com (mail-we0-x231.google.com [IPv6:2a00:1450:400c:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 03FBB1AA0; Fri, 20 Dec 2013 18:01:16 +0000 (UTC) Received: by mail-we0-f177.google.com with SMTP id u56so2839404wes.36 for ; Fri, 20 Dec 2013 10:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bET6xWZS8aFaOBfsk6U2HnIZGN3jk0OZ9hjbeaWp7wc=; b=JpjT1QRIL/Zsn9RTTD0B5/8I4h7MXBkbMEOjzADhdw+PQI528InvkGu25LFD7E+x2g 69o+UeDlVPylmkz2pKC3le8cRmjkbVkbtBlB5+i/g6oL3DP69G9nmpFz4QHN6E/so12C +BLxgu3iZgReiSY6Xr2dHqYjtNjptBi5LatDyFhGdmixxKXNF1Vai53Jcs+cyIeP9ZvS KHecvm/51uIe7M1/tyq6jKsPgD3GITYp8GnRGo1Y/g+aXEJZbtURDhKOY+HU3MDhGA1C bnsFBtGkgkkBvQYnGifPqSFGu407hHfzPDpuCJio9BMjWKCXTUU7LMLmQ3DjEJSNMMD3 gVXg== MIME-Version: 1.0 X-Received: by 10.180.103.193 with SMTP id fy1mr9160868wib.10.1387562475319; Fri, 20 Dec 2013 10:01:15 -0800 (PST) Received: by 10.194.65.37 with HTTP; Fri, 20 Dec 2013 10:01:15 -0800 (PST) In-Reply-To: References: <201312200741.rBK7f3tL038123@svn.freebsd.org> <20131220084419.GK71033@FreeBSD.org> Date: Fri, 20 Dec 2013 10:01:15 -0800 Message-ID: Subject: Re: svn commit: r259642 - head/sys/netinet From: Jack Vogel To: Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Gleb Smirnoff , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Dec 2013 18:01:18 -0000 I agree with Gleb, ifdef 0 is silly, after all, that's why we have source history, its not like the offending code is gone forever :) So I guess its both of us muttering Gleb :) Jack On Fri, Dec 20, 2013 at 9:05 AM, Adrian Chadd wrote: > On 20 December 2013 00:44, Gleb Smirnoff wrote: > > > I didn't get to review of actual patch, but IMO it would be better > > just to remove the code, not ifdef 0 it. The code ifdefed has zero > > probability to be enabled in its current form. If we ever fix it, code > > would look very different. > > > > No reason to do followup commit, that was just me muttering. > > I figured it would be nicer in the short term to #if 0 it out whilst > some other discussions went on, just to make it really obvious in the > short term where the check was done. It's quite possible I'll > eventually just trim it entirely out. > > Thanks, > > > -a >