From owner-svn-src-head@FreeBSD.ORG  Thu Nov 10 03:25:25 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6A172106564A;
	Thu, 10 Nov 2011 03:25:25 +0000 (UTC) (envelope-from ache@vniz.net)
Received: from vniz.net (vniz.net [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id A63808FC14;
	Thu, 10 Nov 2011 03:25:23 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by vniz.net (8.14.5/8.14.5) with ESMTP id pAA3PMiu043229;
	Thu, 10 Nov 2011 07:25:22 +0400 (MSK) (envelope-from ache@vniz.net)
Received: (from ache@localhost)
	by localhost (8.14.5/8.14.5/Submit) id pAA3PMvX043228;
	Thu, 10 Nov 2011 07:25:22 +0400 (MSK) (envelope-from ache)
Date: Thu, 10 Nov 2011 07:25:21 +0400
From: Andrey Chernov <ache@FreeBSD.ORG>
To: Kevin Lo <kevlo@FreeBSD.ORG>
Message-ID: <20111110032521.GA42953@vniz.net>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	Kevin Lo <kevlo@FreeBSD.ORG>, src-committers@FreeBSD.ORG,
	svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG
References: <201111100144.pAA1i6Se008898@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201111100144.pAA1i6Se008898@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	src-committers@FreeBSD.ORG
Subject: Re: svn commit: r227414 - head/lib/libc/regex
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Nov 2011 03:25:25 -0000

On Thu, Nov 10, 2011 at 01:44:06AM +0000, Kevin Lo wrote:
> - == static void p_ere(struct parse *p, int stop);
> + == static void p_ere(struct parse *p, wint_t stop);
>   */
>  static void
>  p_ere(struct parse *p,
> -	int stop)		/* character this ERE should end at */
> +	wint_t stop)		/* character this ERE should end at */
>  {
>  	char c;
>  	sopno prevback;

IMHO mechanical converting char to int (first prototypes "fixing" round), 
then int to wint_t (your next round) will leads to broken things like 
direct comparison of raw char and encoded wint_t:

	while (MORE() && (c = PEEK()) != '|' && c != stop)

while the true prototype for p_ere() is:

static void p_ere(struct parse *p, char stop);

This is the first thing I notice, so the whole patch should be carefully 
inspected and fixed.

-- 
http://ache.vniz.net/