From owner-svn-src-all@freebsd.org  Fri Dec 27 16:28:58 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9D7E91EFFB5;
 Fri, 27 Dec 2019 16:28:58 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47kshp3m94z4Gc0;
 Fri, 27 Dec 2019 16:28:58 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com
 [209.85.219.51])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 6EA1E12E6C;
 Fri, 27 Dec 2019 16:28:58 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qv1-f51.google.com with SMTP id n8so10188786qvg.11;
 Fri, 27 Dec 2019 08:28:58 -0800 (PST)
X-Gm-Message-State: APjAAAXQAksMEtl+mdoHWudewrfxQcH6LoTTIpjOL7RezSn6yPliTHFM
 SlPyhXbxpR7hNjTvS8zBYh0/AmipzShVQaR9K1I=
X-Google-Smtp-Source: APXvYqzOf8O/JVPktAqh/Ij8OiNUKINwoldREXa3wFNVEhcbaYAz8zA5W51R6T7mt55UsrsPTKOE+bXTgIsctEGYADY=
X-Received: by 2002:a05:6214:118d:: with SMTP id
 t13mr39856294qvv.5.1577464137943; 
 Fri, 27 Dec 2019 08:28:57 -0800 (PST)
MIME-Version: 1.0
References: <201912261725.xBQHPq8u076460@repo.freebsd.org>
 <62d80c6e-f0c0-05bb-cb22-b6cf40d4c06f@selasky.org>
In-Reply-To: <62d80c6e-f0c0-05bb-cb22-b6cf40d4c06f@selasky.org>
From: Kyle Evans <kevans@freebsd.org>
Date: Fri, 27 Dec 2019 10:28:46 -0600
X-Gmail-Original-Message-ID: <CACNAnaELpkUxBmOc5xiApisUKfGsdkq8CBAY+wWWKEw5-fse2g@mail.gmail.com>
Message-ID: <CACNAnaELpkUxBmOc5xiApisUKfGsdkq8CBAY+wWWKEw5-fse2g@mail.gmail.com>
Subject: Re: svn commit: r356092 - head/sys/dev/kbdmux
To: Hans Petter Selasky <hps@selasky.org>
Cc: src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>, 
 svn-src-head <svn-src-head@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Dec 2019 16:28:58 -0000

On Fri, Dec 27, 2019 at 9:04 AM Hans Petter Selasky <hps@selasky.org> wrote:
>
> TODO:
>
> Is there a way to distinguish between key events which are key-presses
> and events which are auto-repeated key-presses?
>

At the risk of asking a dumb question, where are you wanting to make
this distinction at?

I haven't thought much about it, but it looks like we could either
burn the last keyflag for it (we haven't added one in at least 13
years) or use `NOKEY | keychar` as an indicator for this, as I think
that would still make logical sense. NOKEY is currently used a
standalone value for 'no key pressed marker', and everything in-tree
seems to check (read_char() == NOKEY) rather than
(KEYFLAGS(read_char()) == NOKEY) for the current interpretation.

Thanks,

Kyle Evans