From owner-freebsd-current Wed Jan 27 22:26:04 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA21382 for freebsd-current-outgoing; Wed, 27 Jan 1999 22:25:43 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from cimlogic.com.au (cimlog.lnk.telstra.net [139.130.51.31]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA21374 for ; Wed, 27 Jan 1999 22:25:39 -0800 (PST) (envelope-from jb@cimlogic.com.au) Received: (from jb@localhost) by cimlogic.com.au (8.9.1/8.9.1) id RAA08066; Thu, 28 Jan 1999 17:29:41 +1100 (EST) (envelope-from jb) From: John Birrell Message-Id: <199901280629.RAA08066@cimlogic.com.au> Subject: Re: btokup() macro in sys/malloc.h In-Reply-To: <199901280620.XAA26671@mt.sri.com> from Nate Williams at "Jan 27, 1999 11:20: 6 pm" To: nate@mt.sri.com (Nate Williams) Date: Thu, 28 Jan 1999 17:29:41 +1100 (EST) Cc: jb@cimlogic.com.au, nate@mt.sri.com, archie@whistle.com, wollman@khavrinen.lcs.mit.edu, current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL43 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Nate Williams wrote: > > Fixing warnings with bad casts is a problem, sure, but asking people > > to write code without casts (if possible) that will compile cleanly with > > -Wall is a reasonable thing to ask IMO. > > Agreed. But most of the new code written does indeed compile with > -Wall. It's the code we've 'inherited' that doesn't. OK, so we can review the fixes and improve things for the future. > > In my experience, the resulting > > code tends to be more portable across architectures with different > > pointer/long sizes and endian-ness. > > This is where I disagree. Too often people cast away the bugs and end > up with overflow and sign problems. We still have Bruce to review code for inappropriate casts etc. Try and stop him. 8-) -- John Birrell - jb@cimlogic.com.au; jb@freebsd.org http://www.cimlogic.com.au/ CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message